Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag module #61393

Merged
merged 4 commits into from Aug 29, 2019

Conversation

@chkp-amiads
Copy link
Contributor

commented Aug 27, 2019

SUMMARY

Checkpoint tag module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

checkpoint

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@chkp-amiads this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@chkp-amiads, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

new_name: My New Tag21
state: present
tags:
add: tag3

This comment has been minimized.

Copy link
@justjais

justjais Aug 27, 2019

Contributor
Suggested change
add: tag3
add: tag3

add params need to be documented

- tag2
- name: set-tag
cp_mgmt_tag:

This comment has been minimized.

Copy link
@justjais

justjais Aug 29, 2019

Contributor

@chkp-amiads can u update the set example here, as currently it's not doing anything extra what add example already performed

This comment has been minimized.

Copy link
@chkp-amiads

chkp-amiads Aug 29, 2019

Author Contributor

Same as for dynaminc object and threat-layer, we can add example of generic attributes like comment, we would like to skip it as it is not a blocker

- name: delete-tag
cp_mgmt_tag:
name: dda885bb-0d5b-4529-96eb-55b757847092

This comment has been minimized.

Copy link
@justjais

justjais Aug 29, 2019

Contributor

@chkp-amiads here name should be My New Tag1 correct?

Suggested change
name: dda885bb-0d5b-4529-96eb-55b757847092
name: My New Tag1

This comment has been minimized.

Copy link
@chkp-amiads

chkp-amiads Aug 29, 2019

Author Contributor

fixed

@justjais justjais merged commit 8768043 into ansible:devel Aug 29, 2019

1 check passed

Shippable Run 140890 status is SUCCESS.
Details

@sivel sivel removed the needs_triage label Aug 29, 2019

adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
tag module (ansible#61393)
* tag module

* list to dict

* removed set example

* fix name in example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.