Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively remove empty values #61395

Open
wants to merge 1 commit into
base: devel
from

Conversation

@wmcbroomd2d
Copy link

commented Aug 27, 2019

SUMMARY

The current implementation of removing null template params doesn't support nested lists which causes problems.

Fixes #61394

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloud/amazon/ec2_launch_template

ADDITIONAL INFORMATION

For example if one of the spot_options is set it till keep the other null options as well. It should remove them leaving only the one that was set.

Before:

    "invocation": {
        "module_args": {
           ...
            "instance_market_options": {
                "market_type": "spot", 
                "spot_options": {
                    "block_duration_minutes": null, 
                    "instance_interruption_behavior": null, 
                    "max_price": null, 
                    "spot_instance_type": "one-time"
                }
            },
            ...
    }

After:

        "launch_template_data": {
            ...
            "instance_market_options": {
                "market_type": "spot", 
                "spot_options": {
                    "spot_instance_type": "one-time"
                }
            },
            ...
         }
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@wmcbroomd2d, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.