Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxos_bfd_interfaces: new module #61407

Merged
merged 13 commits into from Aug 29, 2019

Conversation

@chrisvanheuveln
Copy link
Contributor

commented Aug 27, 2019

SUMMARY

This is a new module to support bfd attributes on interfaces.

This module uses Resource Module Builder. This initial commit includes the following attributes:

  • bfd
    • this keyword is not present on some platforms (N5K, N6K)
    • enable cli does not nvgen
    • disable cli will be present in config as no bfd
  • bfd_echo
    • enable cli does not nvgen
    • disable cli will be present in config as no bfd echo

These new attributes are boolean states but we are using enable/disable states for consistency with bfd options in other modules.

The states are somewhat counter-intuitive when troubleshooting the cli because the enable state does not nvgen even with the show run int all command. There are no alternative show commands to leverage either. When feature bfd is enabled, the module assumes that these bfd keywords are enabled when the disable states are not detected.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

nxos nxos_bfd_interfaces

ADDITIONAL INFORMATION
  • Tested on integration / regression platforms: N3K,N6K,N9K
  • These attributes were originally reviewed as part of #58340, but @cidrblock, @trishnaguha requested they be rewritten to use RMB.
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@chrisvanheuveln this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@chrisvanheuveln chrisvanheuveln force-pushed the chrisvanheuveln:cvh-bfd-interfaces branch from 2e2f0e0 to a197dbd Aug 27, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

The test ansible-test sanity --test pylint [explain] failed with 36 errors:

lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:41:24: bad-whitespace No space allowed after bracket                 'name': { 'type': 'str'},                         ^
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:43:68: bad-whitespace No space allowed before bracket                     'choices': ['enable', 'disable'], 'type': 'str' },                                                                     ^
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:45:68: bad-whitespace No space allowed before bracket                     'choices': ['enable', 'disable'], 'type': 'str' },                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:84: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:100:17: bad-whitespace No space allowed after bracket         merged = [ 'interface Ethernet1/1', 'no bfd', 'no bfd echo',                  ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:134:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:134:84: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:146:17: bad-whitespace No space allowed after bracket         merged = [ 'interface Ethernet1/1', 'bfd', 'no bfd echo' ]                  ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:146:65: bad-whitespace No space allowed before bracket         merged = [ 'interface Ethernet1/1', 'bfd', 'no bfd echo' ]                                                                  ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:147:18: bad-whitespace No space allowed after bracket         deleted = [ 'interface Ethernet1/1', 'bfd',                   ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:148:56: bad-whitespace No space allowed before bracket                     'interface Ethernet1/2', 'bfd echo' ]                                                         ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:149:21: bad-whitespace No space allowed after bracket         overridden = [ 'interface Ethernet1/1', 'bfd',                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:152:69: bad-whitespace No space allowed before bracket                        'interface Ethernet1/1', 'bfd', 'no bfd echo' ]                                                                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:153:19: bad-whitespace No space allowed after bracket         replaced = [ 'interface Ethernet1/1', 'bfd', 'no bfd echo',                    ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:154:57: bad-whitespace No space allowed before bracket                      'interface Ethernet1/2', 'bfd echo' ]                                                          ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:184:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:184:84: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:190:18: bad-whitespace No space allowed after bracket         deleted = [ 'interface Ethernet1/1', 'bfd' ]                   ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:190:51: bad-whitespace No space allowed before bracket         deleted = [ 'interface Ethernet1/1', 'bfd' ]                                                    ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:191:21: bad-whitespace No space allowed after bracket         overridden = [ 'interface Ethernet1/1', 'bfd',                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:193:66: bad-whitespace No space allowed before bracket                        'interface Ethernet1/3', 'bfd', 'bfd echo' ]                                                                   ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:194:19: bad-whitespace No space allowed after bracket         replaced = [ 'interface Ethernet1/1', 'bfd' ]                    ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:194:52: bad-whitespace No space allowed before bracket         replaced = [ 'interface Ethernet1/1', 'bfd' ]                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:219:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:219:84: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:227:17: bad-whitespace No space allowed after bracket         merged = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo' ]                  ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:227:68: bad-whitespace No space allowed before bracket         merged = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo' ]                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:229:21: bad-whitespace No space allowed after bracket         overridden = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo',                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:230:54: bad-whitespace No space allowed before bracket                        'interface Ethernet1/1', 'bfd' ]                                                       ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:231:19: bad-whitespace No space allowed after bracket         replaced = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo' ]                    ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:231:70: bad-whitespace No space allowed before bracket         replaced = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo' ]                                                                       ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:258:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:258:84: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:271:18: bad-whitespace No space allowed after bracket         deleted = [ 'interface Ethernet1/1', 'bfd', 'bfd echo' ]                   ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:271:63: bad-whitespace No space allowed before bracket         deleted = [ 'interface Ethernet1/1', 'bfd', 'bfd echo' ]                                                                ^

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:2215:0: undefined-label: undefined label: nxos_bfd_interfaces_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:1624:0: undefined-label: undefined label: nxos_bfd_interfaces_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 2 errors:

lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:0:0: missing: from __future__ import (absolute_import, division, print_function)
lib/ansible/module_utils/network/nxos/facts/bfd_interfaces/bfd_interfaces.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 2 errors:

lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:0:0: missing: __metaclass__ = type
lib/ansible/module_utils/network/nxos/facts/bfd_interfaces/bfd_interfaces.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test pep8 [explain] failed with 38 errors:

lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:41:26: E201 whitespace after '{'
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:43:68: E202 whitespace before '}'
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:45:68: E202 whitespace before '}'
lib/ansible/modules/network/nxos/nxos_facts.py:60:161: E501 line too long (168 > 160 characters)
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:84: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:100:19: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:134:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:134:84: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:146:19: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:146:65: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:147:20: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:148:56: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:149:23: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:152:69: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:153:21: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:154:57: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:184:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:184:84: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:190:20: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:190:51: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:191:23: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:193:66: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:194:21: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:194:52: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:219:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:219:84: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:227:19: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:227:68: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:229:23: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:230:54: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:231:21: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:231:70: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:258:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:258:84: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:271:20: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:271:63: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:291:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'bfd_interfaces'
lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E319 RETURN.after.type: required key not provided @ data['after']['type']. Got None
lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E319 RETURN.before.type: required key not provided @ data['before']['type']. Got None

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Aug 27, 2019

@trishnaguha trishnaguha self-assigned this Aug 28, 2019

@ansibot ansibot removed the needs_triage label Aug 28, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

The test ansible-test sanity --test pylint [explain] failed with 32 errors:

lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:43:24: bad-whitespace No space allowed after bracket                 'name': { 'type': 'str' },                         ^
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:43:40: bad-whitespace No space allowed before bracket                 'name': { 'type': 'str' },                                         ^
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:45:68: bad-whitespace No space allowed before bracket                     'choices': ['enable', 'disable'], 'type': 'str' },                                                                     ^
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:47:68: bad-whitespace No space allowed before bracket                     'choices': ['enable', 'disable'], 'type': 'str' },                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD : existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:85: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD : existing }                                                                                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:147:18: bad-whitespace No space allowed after bracket         deleted = [ 'interface Ethernet1/1', 'bfd',                   ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:148:56: bad-whitespace No space allowed before bracket                     'interface Ethernet1/2', 'bfd echo' ]                                                         ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:149:21: bad-whitespace No space allowed after bracket         overridden = [ 'interface Ethernet1/1', 'bfd',                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:152:69: bad-whitespace No space allowed before bracket                        'interface Ethernet1/1', 'bfd', 'no bfd echo' ]                                                                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:153:19: bad-whitespace No space allowed after bracket         replaced = [ 'interface Ethernet1/1', 'bfd', 'no bfd echo',                    ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:154:57: bad-whitespace No space allowed before bracket                      'interface Ethernet1/2', 'bfd echo' ]                                                          ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:184:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:184:84: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:190:18: bad-whitespace No space allowed after bracket         deleted = [ 'interface Ethernet1/1', 'bfd' ]                   ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:190:51: bad-whitespace No space allowed before bracket         deleted = [ 'interface Ethernet1/1', 'bfd' ]                                                    ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:191:21: bad-whitespace No space allowed after bracket         overridden = [ 'interface Ethernet1/1', 'bfd',                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:193:66: bad-whitespace No space allowed before bracket                        'interface Ethernet1/3', 'bfd', 'bfd echo' ]                                                                   ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:194:19: bad-whitespace No space allowed after bracket         replaced = [ 'interface Ethernet1/1', 'bfd' ]                    ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:194:52: bad-whitespace No space allowed before bracket         replaced = [ 'interface Ethernet1/1', 'bfd' ]                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:219:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:219:84: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:227:17: bad-whitespace No space allowed after bracket         merged = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo' ]                  ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:227:68: bad-whitespace No space allowed before bracket         merged = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo' ]                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:229:21: bad-whitespace No space allowed after bracket         overridden = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo',                      ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:230:54: bad-whitespace No space allowed before bracket                        'interface Ethernet1/1', 'bfd' ]                                                       ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:231:19: bad-whitespace No space allowed after bracket         replaced = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo' ]                    ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:231:70: bad-whitespace No space allowed before bracket         replaced = [ 'interface Ethernet1/1.42', 'bfd', 'no bfd echo' ]                                                                       ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:258:58: bad-whitespace No space allowed after bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                           ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:258:84: bad-whitespace No space allowed before bracket         self.get_resource_connection_facts.return_value = { self.SHOW_CMD: existing }                                                                                     ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:271:18: bad-whitespace No space allowed after bracket         deleted = [ 'interface Ethernet1/1', 'bfd', 'bfd echo' ]                   ^
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:271:63: bad-whitespace No space allowed before bracket         deleted = [ 'interface Ethernet1/1', 'bfd', 'bfd echo' ]                                                                ^

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:2221:0: undefined-label: undefined label: nxos_bfd_interfaces_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:1626:0: undefined-label: undefined label: nxos_bfd_interfaces_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'bfd_interfaces'
lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E319 RETURN.after.type: required key not provided @ data['after']['type']. Got None
lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E319 RETURN.before.type: required key not provided @ data['before']['type']. Got None

The test ansible-test sanity --test pep8 [explain] failed with 34 errors:

lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:43:26: E201 whitespace after '{'
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:43:40: E202 whitespace before '}'
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:45:68: E202 whitespace before '}'
lib/ansible/module_utils/network/nxos/argspec/bfd_interfaces/bfd_interfaces.py:47:68: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:74: E203 whitespace before ':'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:89:85: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:147:20: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:148:56: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:149:23: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:152:69: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:153:21: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:154:57: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:184:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:184:84: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:190:20: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:190:51: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:191:23: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:193:66: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:194:21: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:194:52: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:219:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:219:84: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:227:19: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:227:68: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:229:23: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:230:54: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:231:21: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:231:70: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:258:60: E201 whitespace after '{'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:258:84: E202 whitespace before '}'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:271:20: E201 whitespace after '['
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:271:63: E202 whitespace before ']'
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:291:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:2221:0: undefined-label: undefined label: nxos_bfd_interfaces_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:1626:0: undefined-label: undefined label: nxos_bfd_interfaces_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'bfd_interfaces'
lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E319 RETURN.after.type: required key not provided @ data['after']['type']. Got None
lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E319 RETURN.before.type: required key not provided @ data['before']['type']. Got None

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:148:21: E127 continuation line over-indented for visual indent
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:150:24: E127 continuation line over-indented for visual indent
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:154:22: E127 continuation line over-indented for visual indent
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:192:24: E127 continuation line over-indented for visual indent
test/units/modules/network/nxos/test_nxos_bfd_interfaces.py:230:24: E127 continuation line over-indented for visual indent

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E319 RETURN.after.type: required key not provided @ data['after']['type']. Got None
lib/ansible/modules/network/nxos/nxos_bfd_interfaces.py:0:0: E319 RETURN.before.type: required key not provided @ data['before']['type']. Got None

click here for bot help

@ansibot ansibot added the ci_verified label Aug 28, 2019

@ansibot ansibot removed the ci_verified label Aug 28, 2019

@ansibot ansibot added core_review and removed needs_revision labels Aug 28, 2019

@trishnaguha trishnaguha merged commit f890c96 into ansible:devel Aug 29, 2019

1 check passed

Shippable Run 140691 status is SUCCESS.
Details
adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
nxos_bfd_interfaces: new module (ansible#61407)
* bfd_interfaces: initial commit

* fix state methods, add more UT

* Add integration tests, support for N6K

* minor comment cleanups

* lint 1

* lint 2

* lint 3

* lint 4

* lint 5

* retrigger shippable

* retrigger shippable

* PR review updates: /bfd_echo/echo/, updated tests

* fix overridden logic and integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.