Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default collection support #61415

Merged
merged 8 commits into from Aug 28, 2019

Conversation

@nitzmahone
Copy link
Member

commented Aug 28, 2019

SUMMARY
  • playbooks run from inside a registered collection will set that collection as the first item in the search order (as will all non-collection roles)
  • this allows easy migration of runme.sh style playbook/role integration tests to collections without the playbooks/roles needing to know the name of their enclosing collection

resolves #59464

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

collection_loader

ADDITIONAL INFORMATION

default collection support
* playbooks run from inside a registered collection will set that collection as the first item in the search order (as will all non-collection roles)
* this allows easy migration of runme.sh style playbook/role integration tests to collections without the playbooks/roles needing to know the name of their enclosing collection
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

The test ansible-test sanity --test required-and-default-attributes [explain] failed with 1 error:

lib/ansible/playbook/collectionsearch.py:35:20: use only one of `default` or `required` with `FieldAttribute`

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Aug 28, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@ansibot ansibot added the test label Aug 28, 2019

@mattclay mattclay removed the needs_triage label Aug 28, 2019

@nitzmahone nitzmahone merged commit 7d1a981 into ansible:devel Aug 28, 2019

adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
default collection support (ansible#61415)
* default collection support

* playbooks run from inside a registered collection will set that collection as the first item in the search order (as will all non-collection roles)
* this allows easy migration of runme.sh style playbook/role integration tests to collections without the playbooks/roles needing to know the name of their enclosing collection

* ignore bogus sanity error

* filed ansible#61460

* fixed task unit test failure

* don't append an empty collections list to the ds

* ignore leftover local_action in mod_args ds action parsing

* fix async_extra_data test to not require ssh and bogus locale

* disable default collection test under Windows

* ensure collection location FS code is always bytes

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.