Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_other module #61450

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@chkp-amiads
Copy link
Contributor

commented Aug 28, 2019

SUMMARY

Checkpoint service_other module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

checkpoint

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@chkp-amiads this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@chkp-amiads, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module cp_mgmt_service_other cp_mgmt_service_other_facts" returned exit status 1.
>>> Standard Error
ERROR! module cp_mgmt_service_other missing documentation (or could not parse documentation): while scanning a simple key
  in "<unicode string>", line 23, column 1
could not find expected ':'
  in "<unicode string>", line 24, column 9

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:99: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 711, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 225, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 124, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "ext/_yaml.pyx", line 707, in _yaml.CParser.get_single_node
  File "ext/_yaml.pyx", line 725, in _yaml.CParser._compose_document
  File "ext/_yaml.pyx", line 776, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 890, in _yaml.CParser._compose_mapping_node
  File "ext/_yaml.pyx", line 776, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 890, in _yaml.CParser._compose_mapping_node
  File "ext/_yaml.pyx", line 776, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 890, in _yaml.CParser._compose_mapping_node
  File "ext/_yaml.pyx", line 774, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 853, in _yaml.CParser._compose_sequence_node
  File "ext/_yaml.pyx", line 905, in _yaml.CParser._parse_next_event
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 23, column 1
could not find expected ':'
  in "<unicode string>", line 24, column 9
make: *** [modules] Error 1

The test ansible-test sanity --test package-data [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/package-data.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 383, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 360, in main
    sdist_path = create_sdist(tmp_dir)
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 174, in create_sdist
    raise Exception('make snapshot failed:\n%s' % stderr)
Exception: make snapshot failed:
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
docs/man/man1/ansible-galaxy.1.rst:51: (WARNING/2) Definition list ends without a blank line; unexpected unindent.
docs/man/man1/ansible-galaxy.1.rst:57: (WARNING/2) Definition list ends without a blank line; unexpected unindent.
ERROR! module cp_mgmt_service_other at /tmp/tmp3f777vkc/lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py has a documentation error formatting or is missing documentation.
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 835, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 102, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 132, in command_release
    plugins = load_plugins(version=version, force_reload=reload_plugins)
  File "packaging/release/changelogs/changelog.py", line 184, in load_plugins
    '--json', '--metadata-dump', '-t', plugin_type])
  File "/usr/lib/python3.6/subprocess.py", line 356, in check_output
    **kwargs).stdout
  File "/usr/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/tmp/tmp3f777vkc/bin/ansible-doc', '--json', '--metadata-dump', '-t', 'module']' returned non-zero exit status 1.
make: *** [changelog] Error 1

The test ansible-test sanity --test validate-modules [explain] failed with 38 errors:

lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E322 Argument 'default_timeout' found in aggressive_aging is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E322 Argument 'enable' found in aggressive_aging is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E322 Argument 'timeout' found in aggressive_aging is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E322 Argument 'use_default_timeout' found in aggressive_aging is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E324 Argument 'wait_for_task' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E326 Argument 'color' in argument_spec defines choices as (['aquamarine', 'black', 'blue', 'crete blue', 'burlywood', 'cyan', 'dark green', 'khaki', 'orchid', 'dark orange', 'dark sea green', 'pink', 'turquoise', 'dark blue', 'firebrick', 'brown', 'forest green', 'gold', 'dark gold', 'gray', 'dark gray', 'light green', 'lemon chiffon', 'coral', 'sea green', 'sky blue', 'magenta', 'purple', 'slate blue', 'violet red', 'navy blue', 'olive', 'orange', 'red', 'sienna', 'yellow']) but documentation defines choices as ([])
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E326 Argument 'details_level' in argument_spec defines choices as (['uid', 'standard', 'full']) but documentation defines choices as ([])
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['present', 'absent']) but documentation defines choices as ([])
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'accept_replies' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'action' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'aggressive_aging' in argument_spec defines type as 'dict' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'auto_publish_session' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'color' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'comments' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'default_timeout' in argument_spec found in aggressive_aging defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'details_level' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'enable' in argument_spec found in aggressive_aging defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'groups' in argument_spec defines type as 'list' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'ignore_errors' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'ignore_warnings' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'ip_protocol' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'keep_connections_open_after_policy_installation' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'match' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'match_for_any' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'override_default_settings' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'session_timeout' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'sync_connections_on_cluster' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'tags' in argument_spec defines type as 'list' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'timeout' in argument_spec found in aggressive_aging defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'use_default_session_timeout' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'use_default_timeout' in argument_spec found in aggressive_aging defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'version' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E337 Argument 'wait_for_task' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:0:0: E340 Argument 'aggressive_aging' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:51:9: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/cp_mgmt_service_other.py:51:9: error DOCUMENTATION: syntax error: could not find expected ':'

click here for bot help

@justjais justjais merged commit 3bc5957 into ansible:devel Aug 29, 2019

1 check passed

Shippable Run 140648 status is SUCCESS.
Details

@sivel sivel removed the needs_triage label Aug 29, 2019

adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
service_other module (ansible#61450)
* service_other module

* fix test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.