Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "maven_artifact.py - add support for version ranges by using spec (#54309)" #61488

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@mattclay
Copy link
Member

commented Aug 28, 2019

SUMMARY

Revert "maven_artifact.py - add support for version ranges by using spec (#54309)"

This reverts commit 145a6a8.

The unit tests in this commit fail when run independently:

ansible-test units test/units/modules/packaging/language/test_maven_artifact.py --docker -v --python 3.7

The commit can be re-submitted once the test issues have been resolved.

>       assert mvn_downloader.find_version_by_spec(artifact) == version_choosed
E       AssertionError: assert '3.8' == '3.8.2'
E         - 3.8
E         + 3.8.2
E         ?    ++

The change is being reverted since it's not clear if the bug is in the module changes, the test, or both.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

lib/ansible/modules/packaging/language/maven_artifact.py

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@turb

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

cc @pjrm

@ansibot ansibot removed the needs_triage label Aug 28, 2019

@mattclay mattclay force-pushed the mattclay:revert-maven branch from 18cbf78 to 352b9ae Aug 28, 2019

@mattclay mattclay merged commit 8521474 into ansible:devel Aug 28, 2019

1 check was pending

Shippable Run 140703 status is PROCESSING.
Details

@mattclay mattclay deleted the mattclay:revert-maven branch Aug 28, 2019

@pjrm

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Hi @mattclay and @turb,

Thanks for the notice. It seems that was an update on the package that I've been using (semantic_version) that corrected a test that had a bug.

I have this fixed. What is the procedure to push the new changes? Re-open this PR 145a6a8 or open a new one?

Thank you.

@gundalow

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Please create a fresh branch and PR (and mention this https://github.com/ansible/ansible/pull/61488 in the description)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.