Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add a download_only option to the apt module #61500

Open
wants to merge 15 commits into
base: devel
from

Conversation

@Taoquitok
Copy link
Contributor

commented Aug 28, 2019

SUMMARY

Added an option in the apt module to allow for downloading packages only as an optional flag when installing or upgrading

Fixes #23220

WIP summary:

  • Fix tests
  • Need to run tests locally and collect output for this PR, and explicitly test that download_only with build-dep works as I believe it would
  • Considering ensuring Download complete and in download only mode is returned in the --diff output from diff = to_native(output).splitlines() if it exists to improve the diff message
    • Additionally consider a download_only return field
  • Update the DOCUMENTATION block to reflect this change
    • Examples
    • Return (if appropriate)
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

apt.py

ADDITIONAL INFORMATION
TODO: Add in example output of before and after

Note: Though #24247 and #45531 exists, as there hasn't been any traction on these pull requests in a long time, I've expanded on their initial work to ensure download_only works consistently with all relevant install and upgrade states, and I'll complete the requires tasks to ensure this pull request is ready to be accepted

Taoquitok and others added 5 commits Aug 21, 2019
Update apt.py with "download_only" switch
Update apt.py with "download_only" switch to allow for pre-downloading of .deb files ahead of a applying the change
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/packaging/os/apt.py:562:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/packaging/os/apt.py:669:15: E121: continuation line under-indented for hanging indent
lib/ansible/modules/packaging/os/apt.py:672:15: E121: continuation line under-indented for hanging indent
lib/ansible/modules/packaging/os/apt.py:951:7: E121: continuation line under-indented for hanging indent

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Taoquitok
Taoquitok
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/packaging/os/apt.py:0:0: option-incorrect-version-added: version_added for new option (download_only) should be '2.10'. Currently StrictVersion ('2.9')

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.