Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nagios module: minor change, added "start" parameter #61562

Open
wants to merge 4 commits into
base: devel
from

Conversation

@dramaley
Copy link
Contributor

commented Aug 29, 2019

SUMMARY

Add a "start" parameter to the nagios module, allowing the user to specify when a scheduled outage in Nagios begins.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nagios.py

ADDITIONAL INFORMATION

This PR finishes the "start" parameter of the nagios module, allowing the user to set when a Nagios downtime should begin. The backend functions within the module already supported a start parameter; this change just exposes that. If the new parameter is not provided, it defaults to the current time. This preserves compability with existing playbooks.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@dramaley this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

dramaley added 3 commits Aug 29, 2019
Finished implementing the "start" parameter to the nagios module. The…
… backend functions already had it; this change just exposes it. This allows setting the time a Nagios outage begins rather than always starting at the time the module was run. If not provided, "start" defaults to the current time (preserving compability with existing playbooks).

@dramaley dramaley force-pushed the dramaley:devel branch from 1691bc1 to 486b86a Aug 29, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@dramaley

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

Closing and reopening to force CI, per the notes on the "needs_ci" and "stale_ci" labels.

@dramaley dramaley reopened this Aug 29, 2019

@goneri goneri removed the stale_ci label Aug 29, 2019

@ansibot ansibot added stale_ci and removed needs_triage labels Aug 29, 2019

@goneri goneri closed this Sep 10, 2019

@goneri goneri reopened this Sep 10, 2019

@goneri

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

I'm not sure what happened with the CI here, it seems to be running this time.

@goneri goneri added the ci_verified label Sep 10, 2019

@ansibot ansibot removed the ci_verified label Sep 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/monitoring/nagios.py:0:0: option-incorrect-version-added: version_added for new option (start) should be '2.10'. Currently StrictVersion ('2.9')

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.