Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix ios_l3_interfaces resource module round trip failure #61642

Open
wants to merge 4 commits into
base: devel
from

Conversation

@justjais
Copy link
Contributor

commented Aug 31, 2019

Signed-off-by: Sumit Jaiswal sjaiswal@redhat.com

SUMMARY

To fix ios_l3_interfaces resource module round trip failure raised in issue #61396

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_l3_interfaces

ADDITIONAL INFORMATION

fix 61396
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot

This comment has been minimized.

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 31, 2019

Build succeeded (third-party-check pipeline).

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2019

@justjais can we add a test here to confirm we don't break in the future?

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2019

recheck

@ansibot ansibot removed the needs_triage label Aug 31, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 31, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@justjais

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 2, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ansibot ansibot added the test label Sep 2, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 2, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

justjais added 2 commits Sep 2, 2019
remove unnecessary config
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
change test description
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 2, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@justjais

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 4, 2019

Build succeeded (third-party-check pipeline).

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 4, 2019

Build succeeded (third-party-check pipeline).

@NilashishC

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

The tests in the PR looks more like an idempotence test rather than RTT test. IMO, RTT tests should do the following:
(a) Set a base config
(b) Gather facts
(c) Apply config that would be reverted
(d) Assert that the above config was applied (which essentially would depict a scenario where the device has been incorrectly configured)
(e) Use the previously gathered facts to revert back to base config.
(f) Assert that the after of the above task == after of task (a), i.e., base config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.