Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme_* modules: deprecate acme_version default, announce that ACME v1 support will be deprecated eventually #61667

Open
wants to merge 7 commits into
base: devel
from

Conversation

@felixfontein
Copy link
Contributor

commented Sep 1, 2019

SUMMARY

Since everyone should use ACME v2 eventually, having acme_version default to 1 is not a good idea anyway.

I also added an announcement in the acme_version documentation that ACME v1 support will eventually be deprecated. Right now, people might still use it, but Let's Encrypt will shut it down eventually (current plan: less than two years from now), and also other CAs should migrate to ACME v2 eventually (assuming that our implementation actually works with their ACME v1 implementation at the moment).

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/acme.py
acme_account
acme_account_info
acme_certificate
acme_certificate_revoke
acme_inspect

@ansibot

This comment has been minimized.

@acozine
Copy link
Contributor

left a comment

This is a nice improvement overall. I see a few ways it could be made even better.

lib/ansible/plugins/doc_fragments/acme.py Outdated Show resolved Hide resolved
@samccann

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

recheck

@samccann

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

Closing and reopening to see if that kickstarts shippable

@samccann samccann closed this Sep 13, 2019

@samccann samccann reopened this Sep 13, 2019

@felixfontein felixfontein force-pushed the felixfontein:acme-version-2 branch from 178ac44 to 160b781 Sep 15, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

Rebased to remove conflict with merged #61648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.