Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure private tag prefix support (fixes azure_vm_virtualmachine idempotency and stranded resources) #61870

Open
wants to merge 1 commit into
base: devel
from

Conversation

@jeking3
Copy link
Contributor

commented Sep 5, 2019

SUMMARY

It was possible for tags used internally to track resources that a module manages (like azure_vm_virtualmachine manages the Storage Account and saves it with own_sa as a tag) to be corrupted by an external update in module params. If the user modified own_sa then the original storage account would be orphaned, and a new one would be created.

Generally, internal tags SHOULD have a better prefix than "own" however that's what is there now.
The azure common update_tags mechanism was updated so that an optional private tag prefix could be specified. Any incoming tag creations or updates on those tags will be ignored and a debug message generated. Any tag deletions that would normally occur on those tags will not occur through the update_tags mechanism (which is used to apply the user's tags in params to the object in question).

Fixes #61767

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_virtualmachine

ADDITIONAL INFORMATION

Without this change if one creates a VM with azure_vm_virtualmachine using a playbook that contains a tag, then runs the playbook again, the old storage account would be orphaned and a new storage account would be created. This issue likely appeared with support for boot diagnostics.


Azure private tag prefix support
- Allow an azure module to specify a tag prefix as private.
- Private tag changes in params generates a debug message.

This fixes #61767
@ansibot

This comment has been minimized.

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

@jeking3 Thanks for your contribution, Could you help fix the Ci fail? when you finished, I will push for review! Thanks a lot!

@ansibot ansibot added the stale_ci label Sep 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.