Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.9] Connect before reading the prompt? (#61797) #61883

Open
wants to merge 3 commits into
base: stable-2.9
from

Conversation

@Qalthos
Copy link
Contributor

commented Sep 5, 2019

(cherry picked from commit a365e77)

Co-authored-by: Nathaniel Case ncase@redhat.com

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

network_cli

Depends-On: #61899

[stable-2.9] Connect before reading the prompt? (#61797)
(cherry picked from commit a365e77)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
@ansibot

This comment has been minimized.

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 5, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

added dependency on iosxr fixes

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

recheck

@ansibot ansibot removed the needs_triage label Sep 6, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 6, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

A changelog is needed for this and then it can be merged.

@ansibot ansibot added needs_ci stale_ci and removed small_patch labels Sep 6, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

The test ansible-test sanity --test package-data [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/package-data.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 383, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 360, in main
    sdist_path = create_sdist(tmp_dir)
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 174, in create_sdist
    raise Exception('make snapshot failed:\n%s' % stderr)
Exception: make snapshot failed:
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
docs/man/man1/ansible-galaxy.1.rst:51: (WARNING/2) Definition list ends without a blank line; unexpected unindent.
docs/man/man1/ansible-galaxy.1.rst:57: (WARNING/2) Definition list ends without a blank line; unexpected unindent.
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 835, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 102, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 135, in command_release
    generate_changelog(changes, plugins, fragments)
  File "packaging/release/changelogs/changelog.py", line 288, in generate_changelog
    rst = generator.generate()
  File "packaging/release/changelogs/changelog.py", line 472, in generate
    combined_fragments = ChangelogFragment.combine([self.fragments[fragment] for fragment in release['fragments']])
  File "packaging/release/changelogs/changelog.py", line 595, in combine
    for section, content in fragment.content.items():
AttributeError: 'list' object has no attribute 'items'
make: *** [changelog] Error 1

The test ansible-test sanity --test changelog [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/changelog.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 835, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 102, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 113, in command_lint
    lint_fragments(fragments, exceptions)
  File "packaging/release/changelogs/changelog.py", line 236, in lint_fragments
    errors += linter.lint(fragment)
  File "packaging/release/changelogs/changelog.py", line 309, in lint
    for section, lines in fragment.content.items():
AttributeError: 'list' object has no attribute 'items'
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/changelog.py", line 26, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/changelog.py", line 22, in main
    subprocess.check_call(cmd)
  File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['packaging/release/changelogs/changelog.py', 'lint', 'changelogs/fragments/61797-netcli-get_prompt.yaml']' returned non-zero exit status 1.

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Sep 6, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

The problem is that the toplevel of the changelog fragment is a dict, not a list.

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 6, 2019

Update changelogs/fragments/61797-netcli-get_prompt.yaml
Co-Authored-By: Toshio Kuratomi <a.badger@gmail.com>
@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 9, 2019

@ansibot ansibot added core_review and removed needs_revision labels Sep 9, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 11, 2019

@Qalthos

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 12, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 12, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.