Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] fix erroneous failures in docker_compose due to deprecation warnings … #61971

Merged
merged 1 commit into from Sep 9, 2019

Conversation

sluther
Copy link
Contributor

@sluther sluther commented Sep 8, 2019

…… (#61650)

Co-Authored-By: Felix Fontein felix@fontein.de

  • update error handling

  • fix syntax error

  • fix indentation

  • fix indentation (again)

  • remove erroneous line

(cherry picked from commit 0c73e47)

SUMMARY

Consistently capture stdout and stderr to prevent any output from causing erroneous failures

fixes #60961

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_compose

ADDITIONAL INFORMATION

ansible#61650)

* fix erroneous failures in docker_compose due to deprecation warnings from docker (ansible#60961)

* Update error handling to work with new method of capturing output

Co-Authored-By: Felix Fontein <felix@fontein.de>

* update error handling

* fix syntax error

* fix indentation

* fix indentation (again)

* remove erroneous line

(cherry picked from commit 0c73e47)
@felixfontein felixfontein changed the title fix erroneous failures in docker_compose due to deprecation warnings … [2.8] fix erroneous failures in docker_compose due to deprecation warnings … Sep 8, 2019
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 9, 2019
@abadger abadger merged commit 3dec34c into ansible:stable-2.8 Sep 9, 2019
@abadger
Copy link
Contributor

abadger commented Sep 9, 2019

Merged for the 2.8.5 release.

@felixfontein
Copy link
Contributor

@sluther thanks for backporting this!
@abadger thanks for merging!

@ansible ansible locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants