Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt: add update_cache_allow_releaseinfo_change option #62824

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

agix
Copy link

@agix agix commented Sep 25, 2019

SUMMARY

This add an option to pass --allow-releaseinfo-change to update_cache

It should fixes #30754

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Change in apt module

@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2019

@ansibot ansibot added affects_2.10 bug core_review module needs_triage new_contributor packaging support:core labels Sep 25, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/packaging/os/apt.py:0:0: option-incorrect-version-added: version_added for new option (update_cache_allow_releaseinfo_change) should be '2.10'. Currently StrictVersion ('2.1')

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/packaging/os/apt.py:1066:19: E111: indentation is not a multiple of four
lib/ansible/modules/packaging/os/apt.py:1068:19: E111: indentation is not a multiple of four
lib/ansible/modules/packaging/os/apt.py:1128:19: E111: indentation is not a multiple of four

click here for bot help

@ansibot ansibot added ci_verified needs_revision core_review and removed core_review ci_verified needs_revision labels Sep 25, 2019
@nitzmahone nitzmahone removed the needs_triage label Oct 3, 2019
lib/ansible/modules/packaging/os/apt.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision and removed core_review labels Oct 3, 2019
@ansibot ansibot added stale_ci stale_review labels Oct 12, 2019
@ansibot ansibot added core_review and removed needs_revision stale_review labels Mar 4, 2020
@ansibot ansibot added needs_revision stale_review has_issue and removed core_review labels Mar 28, 2020
@ansibot ansibot removed the needs_rebase label Jul 23, 2020
@agix agix requested a review from bcoca Jul 23, 2020
@ansibot ansibot added stale_ci stale_review labels Jul 31, 2020
@Akasurde Akasurde changed the title add update_cache_allow_releaseinfo_change option apt: add update_cache_allow_releaseinfo_change option Aug 20, 2020
@asper-ru
Copy link

asper-ru commented Nov 21, 2020

No any movement yet, eh?
Do we wait for review from @bcoca ?

@ansibot ansibot added pre_azp and removed stale_ci stale_review labels Dec 7, 2020
@ansibot ansibot added the needs_rebase label Feb 16, 2021
@bcoca
Copy link
Member

bcoca commented Feb 23, 2021

needs a change log ... i would also like to add tests but not sure how to do that without possibly breaking the apt based images

cc @mattclay

@freeyoung
Copy link

freeyoung commented Aug 16, 2021

Since Debian bullseye was released the day before yesterday, I guess there would be more Ansible users wishing this to be merged earlier.

Copy link

@mds-lord mds-lord left a comment

this option is truly missing and should be added to apt module.

@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2022

@agix this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit and removed needs_revision pre_azp labels Mar 1, 2022
@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2022

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/apt.py:0:0: option-incorrect-version-added: version_added for new option (allow_releaseinfo_change) should be '2.13'. Currently StrictVersion ('2.11')

click here for bot help

@ansibot ansibot added ci_verified needs_revision labels Mar 1, 2022
@ansibot ansibot removed the ci_verified label Mar 1, 2022
@ansibot ansibot added stale_ci stale_review labels Mar 9, 2022
@tagirb
Copy link

tagirb commented Apr 11, 2022

Came across this issue just today. Any news as to when this PR will be merged?

@johnbui423
Copy link
Contributor

johnbui423 commented May 24, 2022

@agix - are you still planning to address the missing changelog comment? That seems to be the only review comment holding this back? See https://docs.ansible.com/ansible/latest/community/development_process.html#community-changelogs for more info on how to do this.
Thanks!

@agix
Copy link
Author

agix commented May 24, 2022

Few years I didn't work with ansible.
If you want to do it, please do.

I may take a look this week otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.10 bug has_issue merge_commit module needs_rebase needs_revision new_contributor packaging stale_ci stale_review support:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants