Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cronvar - use correct binary name #63279

Merged
merged 4 commits into from Oct 9, 2019

Conversation

@samdoran
Copy link
Member

commented Oct 9, 2019

SUMMARY

Fixes #63274

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/system/cronvar.py

Fixes regression introduced by #62554
@samdoran samdoran changed the title crovar - use correct binary name cronvar - use correct binary name Oct 9, 2019
@samdoran

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

We have no tests for this module which is how this bug got in. I would like to add tests.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@bcoca
bcoca approved these changes Oct 9, 2019
@ansibot ansibot removed the needs_triage label Oct 9, 2019
Pull apart cron tests into setup_cron role so it can be used by cron and cronvar tests
@ansibot

This comment has been minimized.

samdoran added 2 commits Oct 9, 2019
This is much better than setting the crontab directly per OS
@samdoran samdoran merged commit 9d01477 into ansible:devel Oct 9, 2019
1 check passed
1 check passed
Shippable Run 146027 status is SUCCESS.
Details
@samdoran samdoran deleted the samdoran:issue/63274-cronvar-not-found branch Oct 9, 2019
samdoran added a commit to samdoran/ansible that referenced this pull request Oct 10, 2019
Fixes regression introduced by ansible#62554
Add integration tests for cronvar.
(cherry picked from commit 9d01477)

Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran added a commit to samdoran/ansible that referenced this pull request Oct 10, 2019
samdoran added a commit to samdoran/ansible that referenced this pull request Oct 10, 2019
abadger added a commit that referenced this pull request Oct 10, 2019
* [stable-2.9] cronvar - use correct binary name (#63279)

Fixes regression introduced by #62554
Add integration tests for cronvar.
(cherry picked from commit 9d01477)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* cron: add integration tests (#59830)

* cron: add integration tests

Use faketime in order to reduce waiting time. Using opensuse15
container:

    Tuesday 30 July 2019  23:03:19 +0000 (0:00:05.410)       0:01:28.291 **********
    ===============================================================================
    cron : install cron and faketime packages ------------------------------ 78.65s
    cron : wait 70 seconds max ---------------------------------------------- 5.41s
    Gathering Facts --------------------------------------------------------- 0.97s
    cron : enable cron service ---------------------------------------------- 0.72s
    cron : Use faketime with cron service ----------------------------------- 0.71s
    cron : command ---------------------------------------------------------- 0.41s
    cron : create directory for cron drop-in file --------------------------- 0.41s
    cron : add cron task ---------------------------------------------------- 0.40s
    cron : command ---------------------------------------------------------- 0.25s
    cron : command ---------------------------------------------------------- 0.25s
    cron : include_vars ----------------------------------------------------- 0.06s

* cron test, simplify: use Environment instead ExecStart

Thanks to mscherer for the suggestion.

* clean up comment: remove reference to outdated path

$OUTPUT_DIR is a plain path which doesn't reference any other
environment variables

* cron test: display elapsed time

* cron test: display some logs in case of failure

* cron test: handle FreeBSD

* cron tests: add checks

(cherry picked from commit 3c8abc0)
samdoran added a commit to samdoran/ansible that referenced this pull request Oct 10, 2019
(cherry picked from commit 9d01477)
abadger added a commit that referenced this pull request Oct 10, 2019
(cherry picked from commit 9d01477)
emschu pushed a commit to emschu/ansible that referenced this pull request Oct 16, 2019
Fixes regression introduced by ansible#62554
Add integration tests for cronvar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.