get_url: Verify checksum using tmpsrc, not dest #64092
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
bug
core_review
module
needs_triage
net_tools
support:core
labels
|
I'll provide an integration test in a few minutes. |
Done, commit was updated! |
Previously, if the checksum of the downloaded file did not match the specified checksum, the *destination* file was removed. This possibly leaves the system that is being provisioned in an invalid state. Instead, the checksum should be calculated on the temporary file only. If there's a mismatch, delete the *temporary* file, not the destination file. This requires checking the checksum before moving the file.
|
@sivel changelog fragment was added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
SUMMARY
Previously, if the checksum of the downloaded file did not match the
specified checksum, the destination file was removed. This possibly
leaves the system that is being provisioned in an invalid state.
Instead, the checksum should be calculated on the temporary file only.
If there's a mismatch, delete the temporary file, not the destination
file.
This requires checking the checksum before moving the file.
ISSUE TYPE
COMPONENT NAME
get_url
ADDITIONAL INFORMATION
Steps to reproduce:
get_urlmodule using the correct checksum. Ensure that the file was downloaded successfully.get_urlmodule