Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman_container_info module #64361

Merged
merged 2 commits into from Dec 6, 2019

Conversation

@sshnaidm
Copy link
Contributor

sshnaidm commented Nov 3, 2019

SUMMARY

Introduce a new module podman_container_info
It collects information of podman containers on the host using podman container inspect command.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

podman_container_info

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Nov 3, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/podman/podman_container_info.py:318:9: return-syntax-error: RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/podman/podman_container_info.py:318:9: error: RETURN: syntax error: expected ',' or ']', but got '}'

click here for bot help

@sshnaidm sshnaidm force-pushed the sshnaidm:podman_container_info branch from 49427e6 to 302c0bd Nov 3, 2019
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Nov 3, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/podman/podman_container_info.py:63:9: return-syntax-error: RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/podman/podman_container_info.py:63:9: error: RETURN: syntax error: could not find expected ':'

click here for bot help

@sshnaidm sshnaidm force-pushed the sshnaidm:podman_container_info branch 4 times, most recently from c5c767e to 0cf9d19 Nov 3, 2019
@sshnaidm

This comment has been minimized.

Copy link
Contributor Author

sshnaidm commented Nov 4, 2019

@sshnaidm sshnaidm force-pushed the sshnaidm:podman_container_info branch from 0cf9d19 to 859b232 Nov 9, 2019
@sshnaidm sshnaidm force-pushed the sshnaidm:podman_container_info branch from 859b232 to b03893f Nov 15, 2019
@sshnaidm

This comment has been minimized.

Copy link
Contributor Author

sshnaidm commented Nov 15, 2019

@felixfontein take a look please, now shouldn't fail if some container doesn't exist.

@sshnaidm sshnaidm force-pushed the sshnaidm:podman_container_info branch 3 times, most recently from 6a5c6c5 to e7effde Nov 15, 2019
@sshnaidm sshnaidm force-pushed the sshnaidm:podman_container_info branch 2 times, most recently from a7fc823 to 9f6d697 Nov 16, 2019
Copy link
Contributor

felixfontein left a comment

LGTM

@ansibot ansibot added shipit and removed community_review labels Nov 16, 2019
@sshnaidm sshnaidm force-pushed the sshnaidm:podman_container_info branch from 9f6d697 to c19f11d Nov 16, 2019
@ansibot ansibot added community_review and removed shipit labels Nov 16, 2019
Copy link
Contributor

felixfontein left a comment

shipit

@ansibot ansibot added shipit and removed community_review labels Nov 17, 2019
@felixfontein

This comment has been minimized.

Copy link
Contributor

felixfontein commented Nov 23, 2019

@samdoran do you want to take a look as well?

@ansibot ansibot added needs_revision and removed shipit labels Dec 2, 2019
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 5, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/podman/podman_container_info.py:0:0: doc-missing-type: Argument 'argument_spec' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/cloud/podman/podman_container_info.py:0:0: nonexistent-parameter-documented: Argument 'name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/podman/podman_container_info.py:0:0: undocumented-parameter: Argument 'argument_spec' is listed in the argument_spec, but not documented in the module documentation

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/podman/podman_container_info.py:390:9: E122: continuation line missing indentation or outdented
lib/ansible/modules/cloud/podman/podman_container_info.py:393:9: E122: continuation line missing indentation or outdented

click here for bot help

@sshnaidm sshnaidm force-pushed the sshnaidm:podman_container_info branch from 7b0459b to fbdae03 Dec 5, 2019
@sshnaidm sshnaidm requested a review from samdoran Dec 5, 2019
Co-Authored-By: Felix Fontein <felix@fontein.de>
@samdoran samdoran merged commit e444e68 into ansible:devel Dec 6, 2019
1 check passed
1 check passed
Shippable Run 152808 status is SUCCESS.
Details
@sivel sivel removed the needs_triage label Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.