Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print() stmts results an task failure, even if the task itself was successfull #65183

Merged

Conversation

@markuman
Copy link
Contributor

markuman commented Nov 22, 2019

SUMMARY

There are print() statements, which results in task errors, even if the task itself was successfull.

This fix should also be backported.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

elb_application_lb

Copy link
Contributor

s-hertel left a comment

shipit

@ansibot ansibot removed the small_patch label Nov 22, 2019
Copy link
Contributor

s-hertel left a comment

As @felixfontein suggested in IRC, we could merge this without a changelog and then add the changelog to the backport to 2.9 that would include the fix here and the relevant bit of #65021 instead.

@markuman

This comment has been minimized.

Copy link
Contributor Author

markuman commented Nov 22, 2019

@s-hertel so should I remove the changelog?

@markuman markuman force-pushed the markuman:remove_print_from_elb_application_lb_module branch from 7558af1 to 48a0200 Nov 22, 2019
@ansibot ansibot added the small_patch label Nov 22, 2019
@s-hertel s-hertel merged commit cba9abc into ansible:devel Nov 22, 2019
1 check passed
1 check passed
Shippable Run 151580 status is SUCCESS.
Details
felixfontein added a commit to felixfontein/ansible that referenced this pull request Nov 23, 2019
@sivel sivel removed the needs_triage label Dec 2, 2019
D3DeFi added a commit to D3DeFi/ansible that referenced this pull request Dec 8, 2019
anshulbehl added a commit to anshulbehl/ansible that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.