Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major rewrite of Netbox implementation support #65651

Open
wants to merge 3 commits into
base: devel
from

Conversation

@BlackestDawn
Copy link

BlackestDawn commented Dec 9, 2019

SUMMARY

Rewriting of Netbox implementation support by moving the shared parts (module_utils/net_tools/netbox/net_utils.py) into a class-object instead of a series of methods. By using a class-object lots of "logic" can be run "automatically" (by init()) and/or be moved into minimum viable versions of class-methods. This has significantly reduced the amount of "logic" needed in the actual modules and they can almost solely focus on the "logic" that is specific to themselves, mainly in preparing the data and how/what to use for specific steps in the overall process.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

netbox_device
netbox_interface
netbox_ip_address
netbox_prefix
netbox_site

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 9, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 9, 2019

The test ansible-test sanity --test pylint [explain] failed with 9 errors:

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:268:11: undefined-variable: Undefined variable 'requests'
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:270:11: undefined-variable: Undefined variable 'socket'
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:550:8: bare-except: No exception type(s) specified
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:586:36: undefined-variable: Undefined variable 'normalize_data'
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:681:0: missing-final-newline: Final newline missing
test/units/module_utils/net_tools/test_netbox.py:72:24: bad-whitespace: No space allowed after bracket     serialized_object = { 'testname': "Some mock object" }                         ^
test/units/module_utils/net_tools/test_netbox.py:72:57: bad-whitespace: No space allowed before bracket     serialized_object = { 'testname': "Some mock object" }                                                          ^
test/units/module_utils/net_tools/test_netbox.py:117:13: bad-whitespace: No space allowed after bracket     before = { "The state before": 1 }              ^
test/units/module_utils/net_tools/test_netbox.py:117:37: bad-whitespace: No space allowed before bracket     before = { "The state before": 1 }                                      ^

The test ansible-test sanity --test pylint [explain] failed with 113 errors:

lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import ALLOWED_QUERY_PARAMS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import API_APPS_ENDPOINTS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import CONVERT_TO_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import DEFAULT_QUERY_PARAM from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import HAS_PYNETBOX from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import INTF_FORM_FACTOR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import INTF_MODE from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import IP_ADDRESS_ROLE from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import IP_ADDRESS_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import NO_DEFAULT_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import PREFIX_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import PYNETBOX_IMP_ERR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import QUERY_PARAMS_IDS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import QUERY_TYPES from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import SITE_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import VLAN_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import build_diff from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import connect_to_api from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import find_app from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: unused-wildcard-import: Unused import ssl from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_device.py:179:0: wildcard-import: Wildcard import ansible.module_utils.net_tools.netbox.netbox_utils
lib/ansible/modules/net_tools/netbox/netbox_device.py:228:24: bad-whitespace: No space allowed after bracket     argument_spec.update( dict(                         ^
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import ALLOWED_QUERY_PARAMS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import API_APPS_ENDPOINTS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import CONVERT_TO_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import DEFAULT_QUERY_PARAM from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import DEVICE_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import FACE_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import HAS_PYNETBOX from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import IP_ADDRESS_ROLE from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import IP_ADDRESS_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import NO_DEFAULT_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import PREFIX_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import PYNETBOX_IMP_ERR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import QUERY_PARAMS_IDS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import QUERY_TYPES from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import SITE_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import VLAN_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import build_diff from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import connect_to_api from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import find_app from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: unused-wildcard-import: Unused import ssl from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_interface.py:209:0: wildcard-import: Wildcard import ansible.module_utils.net_tools.netbox.netbox_utils
lib/ansible/modules/net_tools/netbox/netbox_interface.py:252:24: bad-whitespace: No space allowed after bracket     argument_spec.update( dict(                         ^
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import ALLOWED_QUERY_PARAMS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import API_APPS_ENDPOINTS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import CONVERT_TO_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import DEFAULT_QUERY_PARAM from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import DEVICE_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import FACE_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import HAS_PYNETBOX from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import INTF_FORM_FACTOR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import INTF_MODE from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import NO_DEFAULT_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import PREFIX_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import PYNETBOX_IMP_ERR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import QUERY_PARAMS_IDS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import QUERY_TYPES from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import SITE_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import VLAN_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import build_diff from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import connect_to_api from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import find_app from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: unused-wildcard-import: Unused import ssl from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:228:0: wildcard-import: Wildcard import ansible.module_utils.net_tools.netbox.netbox_utils
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:343:24: bad-whitespace: No space allowed after bracket     argument_spec.update( dict(                         ^
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:358:0: missing-final-newline: Final newline missing
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import ALLOWED_QUERY_PARAMS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import API_APPS_ENDPOINTS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import CONVERT_TO_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import DEFAULT_QUERY_PARAM from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import DEVICE_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import FACE_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import HAS_PYNETBOX from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import INTF_FORM_FACTOR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import INTF_MODE from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import IP_ADDRESS_ROLE from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import IP_ADDRESS_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import NO_DEFAULT_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import PYNETBOX_IMP_ERR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import QUERY_PARAMS_IDS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import QUERY_TYPES from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import SITE_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import VLAN_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import build_diff from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import connect_to_api from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import find_app from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: unused-wildcard-import: Unused import ssl from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:236:0: wildcard-import: Wildcard import ansible.module_utils.net_tools.netbox.netbox_utils
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:341:24: bad-whitespace: No space allowed after bracket     argument_spec.update( dict(                         ^
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:360:0: missing-final-newline: Final newline missing
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import ALLOWED_QUERY_PARAMS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import API_APPS_ENDPOINTS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import CONVERT_TO_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import DEFAULT_QUERY_PARAM from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import DEVICE_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import FACE_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import HAS_PYNETBOX from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import INTF_FORM_FACTOR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import INTF_MODE from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import IP_ADDRESS_ROLE from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import IP_ADDRESS_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import NO_DEFAULT_ID from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import PREFIX_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import PYNETBOX_IMP_ERR from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import QUERY_PARAMS_IDS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import QUERY_TYPES from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import VLAN_STATUS from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import build_diff from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import connect_to_api from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import find_app from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: unused-wildcard-import: Unused import ssl from wildcard import
lib/ansible/modules/net_tools/netbox/netbox_site.py:199:0: wildcard-import: Wildcard import ansible.module_utils.net_tools.netbox.netbox_utils

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 2 errors:

test/sanity/ignore.txt:241:1: Ignoring 'lib/ansible/module_utils/net_tools/netbox/netbox_utils.py' is unnecessary
test/sanity/ignore.txt:6359:1: Ignoring 'test/units/module_utils/net_tools/test_netbox.py' is unnecessary

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/sanity/ignore.txt:6360:1: Ignoring 'test/units/module_utils/net_tools/test_netbox.py' is unnecessary

The test ansible-test sanity --test pep8 [explain] failed with 34 errors:

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:234:1: E302: expected 2 blank lines, found 1
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:249:1: E302: expected 2 blank lines, found 1
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:255:1: E302: expected 2 blank lines, found 1
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:287:1: E302: expected 2 blank lines, found 1
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:310:1: E302: expected 2 blank lines, found 1
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:550:9: E722: do not use bare 'except'
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:681:36: W292: no newline at end of file
lib/ansible/modules/net_tools/netbox/netbox_device.py:189:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_device.py:223:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_device.py:228:26: E201: whitespace after '('
lib/ansible/modules/net_tools/netbox/netbox_device.py:242:1: E305: expected 2 blank lines after class or function definition, found 1
lib/ansible/modules/net_tools/netbox/netbox_interface.py:222:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_interface.py:247:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_interface.py:252:26: E201: whitespace after '('
lib/ansible/modules/net_tools/netbox/netbox_interface.py:268:1: E305: expected 2 blank lines after class or function definition, found 1
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:240:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:273:21: E122: continuation line missing indentation or outdented
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:274:21: E122: continuation line missing indentation or outdented
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:338:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:343:26: E201: whitespace after '('
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:357:1: E305: expected 2 blank lines after class or function definition, found 1
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:358:11: W292: no newline at end of file
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:249:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:336:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:341:26: E201: whitespace after '('
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:359:1: E305: expected 2 blank lines after class or function definition, found 1
lib/ansible/modules/net_tools/netbox/netbox_prefix.py:360:11: W292: no newline at end of file
lib/ansible/modules/net_tools/netbox/netbox_site.py:212:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_site.py:240:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/net_tools/netbox/netbox_site.py:261:1: E305: expected 2 blank lines after class or function definition, found 1
test/units/module_utils/net_tools/test_netbox.py:72:26: E201: whitespace after '{'
test/units/module_utils/net_tools/test_netbox.py:72:57: E202: whitespace before '}'
test/units/module_utils/net_tools/test_netbox.py:117:15: E201: whitespace after '{'
test/units/module_utils/net_tools/test_netbox.py:117:37: E202: whitespace before '}'

click here for bot help

Alexander Stauch added 2 commits Dec 9, 2019
@BlackestDawn BlackestDawn force-pushed the BlackestDawn:netbox branch from fe8c7dc to 1730c6e Dec 9, 2019
@ansibot ansibot removed the ci_verified label Dec 9, 2019
Alexander Stauch
@ansibot ansibot added core_review and removed needs_revision labels Dec 9, 2019
@FragmentedPacket

This comment has been minimized.

Copy link
Contributor

FragmentedPacket commented Dec 9, 2019

Hey I really appreciate your effort on this. I'm no longer supporting the Netbox modules within core and they've been moved to Ansible Collections under fragmentedpacket/netbox_modules. There is a link to the Github for these as well.

I did a big rewrite to move everything into classes earlier this year and that is what the collections are using.

@ansibot ansibot removed the needs_triage label Dec 9, 2019
@FragmentedPacket

This comment has been minimized.

Copy link
Contributor

FragmentedPacket commented Dec 9, 2019

This move was made due to Ansible planning to move most modules out of core and into Ansible Collections. I would love to keep you involved though with the collections if you're using them and any possible improvements you think they need

@ansibot ansibot added the stale_ci label Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.