Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move patch_ansible_module to a pytest plugin #66430

Draft
wants to merge 20 commits into
base: devel
Choose a base branch
from
Draft

Move patch_ansible_module to a pytest plugin #66430

wants to merge 20 commits into from
+910 −404

Conversation

webknjaz
Copy link
Member

This patch automatically loads patch_ansible_module fixture into
pytest when running ansible-test units. It previously existed
in conftest.py hence only available to tests of ansible/ansible
itself. Now, third-party collections will be able to use it without
having to vendor the source code.

SUMMARY

As per above: this exposes patch_ansible_module fixture to any unit tests executed via ansible-test.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-test

ADDITIONAL INFORMATION

N/A

@ansibot

This comment was marked as outdated.

Sign in to view
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 13, 2020
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 13, 2020
@webknjaz webknjaz force-pushed the features/patch_ansible_module-pytest-fixture branch from 1d8fb63 to 4768355 Compare January 13, 2020 20:27
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 13, 2020
@webknjaz webknjaz mentioned this pull request Jan 13, 2020
Closed
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added has_issue new_plugin This PR includes a new plugin. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 13, 2020
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 13, 2020
@webknjaz webknjaz force-pushed the features/patch_ansible_module-pytest-fixture branch from 4768355 to c0ee9ee Compare January 13, 2020 21:47
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 13, 2020
@webknjaz webknjaz force-pushed the features/patch_ansible_module-pytest-fixture branch from c0ee9ee to 2b4e004 Compare January 13, 2020 22:08
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 13, 2020
@webknjaz
Move patch_ansible_module to a pytest plugin
4abc736 
This patch automatically loads patch_ansible_module fixture into
pytest when running `ansible-test units`. It previously existed
in `conftest.py` hence only available to tests of ansible/ansible
itself. Now, third-party collections will be able to use it without
having to vendor the source code.
@webknjaz
Mv units.module_utils.conftest to a pytest plugin
fd96f91
@webknjaz
Add missing fixture docstrings
a73b27d
@webknjaz
Drop unnecessary input double-patch
5baf14a
@webknjaz
Migrate patching input to use monkeypatch
9b5a2a7
@webknjaz
Replace mocker.patch w/ monkeypatch in stdin
c2b61cc
@webknjaz
Use monkeypatch in patch_ansible_module
0500988
@webknjaz
Refactor stdin monkeypatch
da1fcbe
@webknjaz
Refactor patch_ansible_module dict construction
0625d8d
@webknjaz
Simplify args setup in stdin fixture
64c4aee
@webknjaz
Unify args bytes construction
f06414c
@webknjaz
Use stdin fixture instead of patch_ansible_module
2b95973
@webknjaz
Rename stdin fixture to ansible_module_args
eab4696
@webknjaz
Replace am fixture w/ ansible_module
0b9bf1a
@webknjaz
Document pytest fixtures for module unit-tests
5b4c415
@webknjaz
Add example use of fixtures in test+pip
bebc686
@webknjaz
Add a draft of the mocked module runner
dc7eb80
@webknjaz
Use six.PY2 for Python 3+ checks
21c50e2
@webknjaz
tests! test_pip
dfc1da5
@webknjaz webknjaz force-pushed the features/patch_ansible_module-pytest-fixture branch from edcb5a1 to dfc1da5 Compare May 29, 2023 17:39
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 29, 2023
@mkrizek
Copy link
Contributor

mkrizek commented Jun 7, 2023

!waffling stale_ci

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 7, 2023
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 1, 2023
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_review Updates were made after the last review and the last review is more than 7 days old. and removed has_issue labels Jul 12, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattclay mattclay mattclay requested changes

@bcoca bcoca Awaiting requested review from bcoca

@mkrizek mkrizek Awaiting requested review from mkrizek

Requested changes must be addressed to merge this pull request.

Assignees

@webknjaz webknjaz

Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud collection Related to Ansible Collections work docker docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category new_plugin This PR includes a new plugin. packaging Packaging category remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@webknjaz @ansibot @mattclay @bvitnik @mariolenz @samdoran @mkrizek @Akasurde