Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix omapi_host on python3 (#67559) #67560

Closed
wants to merge 2 commits into from
Closed

Fix omapi_host on python3 (#67559) #67560

wants to merge 2 commits into from

Conversation

amasolov
Copy link

SUMMARY

Fixes #67559

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module omapi_host

@amasolov amasolov changed the title [2.9] Fix omapi_host on python3 (#67559) Fix omapi_host on python3 (#67559) Feb 19, 2020
@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2020

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. python3 support:community This issue/PR relates to code supported by the Ansible community. labels Feb 19, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 27, 2020
@amasolov
Copy link
Author

ready_for_review

Copy link
Contributor

@nerzhul nerzhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me, thanks

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 12, 2020
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 28, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@jeanfabrice
Copy link
Contributor

Hi,
same issue here. Can this be merged?

@amasolov
Copy link
Author

Moved to #788 in ansible-collections/community.general

@amasolov amasolov closed this Aug 17, 2020
@ansible ansible locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. collection:community.general collection Related to Ansible Collections work module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. python3 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

omapi_host fails on python3 with TypeError: a bytes-like object is required, not 'str'
4 participants