Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in document docker_swarm_service #67991

Closed
wants to merge 2 commits into from
Closed

Fix typo in document docker_swarm_service #67991

wants to merge 2 commits into from

Conversation

aniejek
Copy link

@aniejek aniejek commented Mar 4, 2020

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY

mount property doesn't have property mode, but type

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docker_swarm_service

@aniejek
Fix typo in document docker_swarm_service
a32289d 
mount property doesn't have property mode, but type

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Mar 4, 2020

cc @DBendit @WojciechowskiPiotr @akshay196 @danihodovic @dariko @felixfontein @hannseman @jwitko @kassiansun @tbouvet
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cloud community_review In order to be merged, this PR must follow the community review workflow. docker docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 4, 2020
@hannseman
Copy link
Contributor

hannseman commented Mar 4, 2020 •
edited

Thanks!

I found some more places where the wrong option is referred:

ansible/lib/ansible/modules/cloud/docker/docker_swarm_service.py

Line 315 in a32289d

- Can only be used when I(mode) is C(bind).

ansible/lib/ansible/modules/cloud/docker/docker_swarm_service.py

Line 328 in a32289d

- Can only be used when I(mode) is C(volume).

ansible/lib/ansible/modules/cloud/docker/docker_swarm_service.py

Line 351 in a32289d

- Can only be used when I(mode) is C(tmpfs).

ansible/lib/ansible/modules/cloud/docker/docker_swarm_service.py

Line 357 in a32289d

- Can only be used when I(mode) is C(tmpfs).

Would you like to push fixes for these as well?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 4, 2020
@felixfontein
Copy link
Contributor

Please note that the ansible/ansible repository is currently in lockdown. Most modules will be migrated to collection repositories over the next weeks. PRs will need to be moved, but there will be a migration tool for that. More info will follow over the next weeks.

It's still OK to use PRs here to polish the changes, but these PRs won't be merged here. So please be patient :)

@aniejek
Copy link
Author

aniejek commented Mar 6, 2020

@hannseman sure

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 14, 2020
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 30, 2020
@felixfontein
Copy link
Contributor

The community.general collection is the new place where the docker_* modules live. The repositority is not done yet (CI isn't working properly in all cases etc.), but if you don't mind that not everything is yet perfect, you can already create a PR there.

For testing, it makes sense to checkout community.general into a folder ansible_collections/community/general. Then you can point the environment variable ANSIBLE_COLLECTIONS_PATHS to the directory containing ansible_collections, and use the modules by their new name community.general.docker_*. That should already work with Ansible 2.9.

Once the PR is there and works, it can be merged and then backported to stable-2.9 here, and then end up in the next 2.9.x release.

@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 24, 2020
@Akasurde
Copy link
Member

@aniejek Are you working on this? If yes, please migrate this PR to community.general since docker_* modules migrated there.

Thanks.

needs_info

@ansibot ansibot added the needs_info This issue requires further information. Please answer any outstanding questions. label Jul 2, 2020
@WojciechowskiPiotr WojciechowskiPiotr mentioned this pull request Jul 2, 2020
Merged
@felixfontein
Copy link
Contributor

Fixed in community.general. Thanks for reporting this @aniejek

close_me

@Akasurde
Copy link
Member

Akasurde commented Jul 3, 2020

superseded by ansible-collections/community.general#608

@aniejek Thanks for the contribution.

@Akasurde Akasurde closed this Jul 3, 2020
@ansible ansible locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud collection:community.general collection Related to Ansible Collections work docker docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_info This issue requires further information. Please answer any outstanding questions. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aniejek @ansibot @hannseman @felixfontein @Akasurde