Skip to content

Add support for iptables match addrtype#68607

Closed
rhazdon wants to merge 1 commit into
ansible:develfrom
rhazdon:devel
Closed

Add support for iptables match addrtype#68607
rhazdon wants to merge 1 commit into
ansible:develfrom
rhazdon:devel

Conversation

@rhazdon
Copy link
Copy Markdown

@rhazdon rhazdon commented Apr 1, 2020

SUMMARY

The linux package iptables has a support for controlling address types. Address types are used within the kernel networking stack and categorize addresses into various groups.
If the --match option is set to addrtype, a --src-type or --dst-type is required.

A good example where this is necessary is docker.

iptables -t nat -A OUTPUT ! -d 127.0.0.0/8 -m addrtype --dst-type LOCAL -j DOCKER.

Docs about addrtype can be found here: https://linux.die.net/man/8/iptables.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iptables

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels Apr 1, 2020
@ansibot
Copy link
Copy Markdown
Contributor

ansibot commented Apr 1, 2020

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/system/iptables.py:0:0: option-incorrect-version-added: version_added for new option (dst_type) should be '2.10'. Currently StrictVersion ('0.0')
lib/ansible/modules/system/iptables.py:0:0: option-incorrect-version-added: version_added for new option (src_type) should be '2.10'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 1, 2020
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 8, 2020
@ansibot
Copy link
Copy Markdown
Contributor

ansibot commented Apr 8, 2020

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/system/iptables.py:0:0: option-incorrect-version-added: version_added for new option (dst_type) should be '2.10'. Currently StrictVersion ('0.0')
lib/ansible/modules/system/iptables.py:0:0: option-incorrect-version-added: version_added for new option (src_type) should be '2.10'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 8, 2020
@rhazdon
Copy link
Copy Markdown
Author

rhazdon commented Apr 9, 2020

It seems like there is the version-added thing missing... Is there something I can do right now or should I just wait?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 16, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 15, 2020
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md support:community This issue/PR relates to code supported by the Ansible community. labels May 23, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 9, 2020
@rhazdon
Copy link
Copy Markdown
Author

rhazdon commented Jun 24, 2021

Is there anything I can do here? :D

@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Oct 14, 2021
@sivel
Copy link
Copy Markdown
Member

sivel commented Apr 13, 2022

#75415 (comment)

@sivel sivel added the iptables label Apr 13, 2022
@nitzmahone
Copy link
Copy Markdown
Member

nitzmahone commented Aug 24, 2022

closing per linked comment above

@nitzmahone nitzmahone closed this Aug 24, 2022
@ansible ansible locked and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

affects_2.10 This issue/PR affects Ansible v2.10 collection Related to Ansible Collections work feature This issue/PR relates to a feature request. iptables module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. pre_azp This PR was last tested before migration to Azure Pipelines. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhazdon @ansibot @sivel @nitzmahone @mattclay