Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid roles exporting vars: #69040

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Avoid roles exporting vars: #69040

wants to merge 1 commit into from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 20, 2020

also correct vars: precedence to allow phasing out of include_params

Fixes #47606
Fixes #36274
Fixes #15243

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

roles

@bcoca bcoca added bug core_review needs_triage support:core labels Apr 22, 2020
@bcoca bcoca removed the needs_triage label Apr 23, 2020
@ansibot ansibot added affects_2.10 has_issue labels Apr 24, 2020
jimi-c
jimi-c approved these changes Apr 27, 2020
@sivel
Copy link
Member

@sivel sivel commented Apr 27, 2020

I think generally speaking, I am in favor of this. However...isn't this technically a backwards incompatible change? Might users now be relying on this behavior?

@ansibot ansibot added the support:community label Apr 27, 2020
@ansibot

This comment has been minimized.

@ansibot ansibot added needs_revision and removed core_review labels Apr 27, 2020
@bcoca
Copy link
Member Author

@bcoca bcoca commented Apr 28, 2020

@sivel, it is, but i'm mapping the different cases to see the level of impact

@ansibot

This comment has been minimized.

@ansibot ansibot added core_review and removed needs_revision labels May 1, 2020
@ansibot ansibot added needs_revision and removed core_review labels May 5, 2020
@bcoca bcoca changed the title avoid roles exporting vars: [WIP] avoid roles exporting vars: May 7, 2020
@ansibot ansibot added the WIP label May 7, 2020
@ansibot ansibot added the stale_ci label May 28, 2020
@s-hertel s-hertel assigned s-hertel and unassigned s-hertel Jun 4, 2020
@ansibot ansibot added core_review needs_revision and removed WIP needs_revision stale_ci core_review labels Jul 6, 2021
@samdoran samdoran added the ci_verified label Jul 7, 2021
@ansibot ansibot added core_review ci_verified needs_revision and removed ci_verified needs_revision core_review labels Jul 8, 2021
@ansibot ansibot added the stale_ci label Jul 16, 2021
@ansibot ansibot added the needs_rebase label Sep 2, 2021
@jborean93 jborean93 added affects_2.14 and removed affects_2.10 labels Jun 8, 2022
@ansibot ansibot added core_review and removed ci_verified needs_rebase needs_revision stale_ci labels Jun 17, 2022
changelogs/fragments/role_vars_scope_fix.yml Outdated Show resolved Hide resolved
lib/ansible/playbook/role/__init__.py Show resolved Hide resolved
lib/ansible/playbook/role_include.py Outdated Show resolved Hide resolved
lib/ansible/vars/manager.py Outdated Show resolved Hide resolved
lib/ansible/vars/manager.py Show resolved Hide resolved
 - correct 'vars:' precedence to allow phasing out of include_params
 - actually merge vars and always include role_vars
 - avoided dupe deps from giving wrong vars
 - use 'first' instance of dep as others are from previous instances/invocations
   and can have diff values for vars
 - ensured deps only provide exportable vars themselves
 - added COMMENTS
 - added tests
 - apply export restrictions setting to defaults
 - use 'public' as cutoff

Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>

ci_complete
@ansibot ansibot added the stale_ci label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.14 bug collection core_review has_issue stale_ci support:community support:core
Projects
None yet
7 participants