Avoid roles exporting vars: #69040

bcoca · 2020-04-20T13:44:54Z

also correct vars: precedence to allow phasing out of include_params

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

roles

sivel · 2020-04-27T16:46:44Z

I think generally speaking, I am in favor of this. However...isn't this technically a backwards incompatible change? Might users now be relying on this behavior?

bcoca · 2020-04-28T06:15:49Z

@sivel, it is, but i'm mapping the different cases to see the level of impact

changelogs/fragments/role_vars_scope_fix.yml

lib/ansible/playbook/role/__init__.py

lib/ansible/playbook/role_include.py

lib/ansible/vars/manager.py

changelogs/fragments/role_vars_scope_fix.yml

- correct 'vars:' precedence to allow phasing out of include_params - actually merge vars and always include role_vars - avoided dupe deps from giving wrong vars - use 'first' instance of dep as others are from previous instances/invocations and can have diff values for vars - ensured deps only provide exportable vars themselves - added COMMENTS - added tests - apply export restrictions setting to defaults - use 'public' as cutoff Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com> ci_complete

bcoca added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 22, 2020

bcoca mentioned this pull request Apr 23, 2020

Ansible role dependencies are not passing variables as expected #68922

Closed

bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 23, 2020

ansibot added affects_2.10 This issue/PR affects Ansible v2.10 has_issue labels Apr 24, 2020

jimi-c approved these changes Apr 27, 2020

View changes

ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Apr 27, 2020

This comment has been minimized.

Sign in to view

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 27, 2020

bcoca mentioned this pull request Apr 28, 2020

Vars have wrong value when including a role from a dependency #69179

Closed

sivel mentioned this pull request May 1, 2020

Future variable overrides are substituted before being defined #69269

Closed

This comment has been minimized.

Sign in to view

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 1, 2020

bcoca mentioned this pull request May 4, 2020

dependencies role vars are inherited by role which depends on them #69298

Open

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 5, 2020

bcoca changed the title ~~avoid roles exporting vars:~~ [WIP] avoid roles exporting vars: May 7, 2020

ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label May 7, 2020

bcoca mentioned this pull request May 8, 2020

role params definition and precedence inconsistency #69388

Open

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 28, 2020

bcoca mentioned this pull request Jun 1, 2020

Modified "vars:" not visible inside include_role. #69799

Open

s-hertel assigned s-hertel and unassigned s-hertel Jun 4, 2020

bcoca force-pushed the rv_fix branch from 9b2f007 to 62c7660 Compare Jul 6, 2021

samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jul 7, 2021

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 16, 2021

ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 2, 2021

jborean93 added affects_2.14 and removed affects_2.10 This issue/PR affects Ansible v2.10 labels Jun 8, 2022

bcoca force-pushed the rv_fix branch from 34c0215 to cea8f21 Compare Jun 17, 2022

s-hertel reviewed Jun 22, 2022

View changes

s-hertel approved these changes Jun 23, 2022

View changes

s-hertel reviewed Jun 23, 2022

View changes

changelogs/fragments/role_vars_scope_fix.yml Outdated Show resolved Hide resolved

bcoca force-pushed the rv_fix branch from aa8c0d1 to 6d2f616 Compare Jun 23, 2022

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 1, 2022

Avoid roles exporting vars: #69040

Avoid roles exporting vars: #69040

bcoca commented Apr 20, 2020 •

edited

sivel commented Apr 27, 2020

This comment has been minimized.

bcoca commented Apr 28, 2020

This comment has been minimized.

Avoid roles exporting vars: #69040

Are you sure you want to change the base?

Avoid roles exporting vars: #69040

Conversation

bcoca commented Apr 20, 2020 • edited

ISSUE TYPE

COMPONENT NAME

sivel commented Apr 27, 2020

This comment has been minimized.

bcoca commented Apr 28, 2020

This comment has been minimized.

bcoca commented Apr 20, 2020 •

edited