Strategy Plugin Support Custom Options

[kevin-j-smith]

Signed-off-by: Kevin J. Smith kevin.j.smith2@cerner.com

SUMMARY

Added custom options to strategy by inheriting ansible.plugins.AnsiblePlugin and adding host_pinned as an option to free to deprecate host_pinned.

Fixes #69668

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

Strategy Plugin Support Custom Options through Inheriting AnsiblePlugin

ADDITIONAL INFORMATION

See changes made to ansible.plugins.strategy.free that now obsoletes ansible.plugins.strategy.host_pinned

See how host_pinned can be used through env:
test/integration/targets/blocks/runme.sh:L27

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/strategy/free.py:37:112: W291: trailing whitespace

click here for bot help

[kevin-j-smith]

I see that this failed, but it is not clear how to correct it or even test it.

[kevin-j-smith]

These 2 failing tests passed before I removed the extra space on the initial run's only failure. Is this a test timing issue?

[kevin-j-smith]

Yeah, just as I suspected. I made a trivial change, check-ed it in and the 2 test failure now pass and 1 new test failure. :(

[bcoca]

i was also thinking of expanding strategy in the playbook itself:

strategy:
  name: free
  host_pinned: true|false

with 'if string' auto assigning to name as backwards compatible change.

[kevin-j-smith]

@bcoca that was another thought I had which also works. I am thinking both solutions would work well together, if that implementation doesn't make the code too complex. Your piece would be handy when playbooks have multiple plays with different strategies. In production, we have built a utility node whose /etc/ansible/ansible.cfg is what is used by all executions. But in other scenarios overriding that within the playbook would be handy.

Do you know how I can re-run the failed tests so that I can get a passible shippable run?

[mkrizek]

@kevin-j-smith The tests have been re-run manually and all passed now but FYI there are bot commands that you can use to rebuild either all or failed tests, see https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md#commands.