transparent downstream vendoring #69850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
This comment has been minimized.
This comment has been minimized.
nitzmahone
removed
the
needs_triage
This comment has been minimized.
This comment has been minimized.
webknjaz
reviewed
Jun 5, 2020
webknjaz
reviewed
Jun 5, 2020
webknjaz
reviewed
Jun 5, 2020
webknjaz
reviewed
Jun 5, 2020
webknjaz
reviewed
Jun 5, 2020
webknjaz
reviewed
Jun 5, 2020
ansibot
added
the
stale_ci
nitzmahone
force-pushed
the
conditional_vendoring
branch
from
598a809
to
849c9f0
Compare
* allows downstream packagers to install packages to `ansible/_vendor` that will automatically be added to head of sys.path during `ansible` package load * tests
nitzmahone
force-pushed
the
conditional_vendoring
branch
from
849c9f0
to
077e6a0
Compare
nitzmahone
changed the title
ansibot
added
core_review
mattclay
reviewed
Jun 15, 2020
mattclay
reviewed
Jun 15, 2020
ansibot
removed
the
core_review
ansibot
added
needs_revision
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
SUMMARY
Upstream supported transparent conditional vendoring for downstream packagers. Allows arbitrary packages to be installed beneath
ansible._vendorat packaging time, which will be added to the head of sys.path. The content beneath the_vendorpackage is masked from the loader (by setting the package's path to[]), preventing any dual-loading issues from occurring.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION