Fix fallback to unshallowing shallow clone#70252
Open
elmeriniemela wants to merge 1 commit into
Open
Conversation
ansibot
added
affects_2.11
bug
relrod
added
P3
Contributor
|
Can you add a test to show what this is solving, and a changelog fragment? |
ansibot
added
the
stale_ci
ansibot
added
needs_revision
Member
|
@elmeriniemela Are you still working on this? Thanks. needs_info |
ansibot
added
the
needs_info
Author
|
@Akasurde Not really, unfortunately I don't have the resources to develop the tests related to this. Feel free to take this issue further. |
ansibot
removed
the
needs_info
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
core_review
ansibot
added
the
stale_ci
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
needs_revision
Member
|
This needs a rebase for the CI to pick up the branch. |
webknjaz
added
the
ci_verified
ansibot
removed
the
ci_verified
webknjaz
added
the
ci_verified
ansibot
added
the
stale_ci
Akasurde
added
the
needs_info
Contributor
|
@elmeriniemela This PR is waiting for your response. Please respond or the PR will be closed. |
Author
|
Hi, the comment in the code explains why depth argument is needed when 'refspecs' variable is empty. However the condition adds it only when "if refspecs" when it should be "if not refspecs". So there is clearly a contradiction with the intention of the developer (expressed in comment) and the actual code. And this causes an error as explained in the PR description. |
Currently git may not find the correct commit with depth=1000000 and shallow clone, caused by an error in the final fall back if clause. The comment in the if clause is correct, just missing a 'not' operator for the comment / behavior to work.
elmeriniemela
force-pushed
the
patch-1
branch
from
c2902a3 to
f6c30fe
Compare
ansibot
removed
needs_info
ansibot
added
the
stale_ci
ansibot
added
the
stale_pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently git may not find the correct commit with depth=1000000 and a shallow clone, caused by an error in the final fall back if clause. The comment in the if clause is correct, just missing a 'not' operator for the comment / behavior to work.
ISSUE TYPE
COMPONENT NAME
git
ADDITIONAL INFORMATION
Reproduce steps: