Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback to unshallowing shallow clone #70252

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

elmeriniemela
Copy link

@elmeriniemela elmeriniemela commented Jun 24, 2020

Currently git may not find the correct commit with depth=1000000 and a shallow clone, caused by an error in the final fall back if clause. The comment in the if clause is correct, just missing a 'not' operator for the comment / behavior to work.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

git

ADDITIONAL INFORMATION

Reproduce steps:

  • Clone repo with 2 commits and depth=1 (shallow clone)
  • Try updating the repo using ansible to the initial commit with depth=2
  • error: pathspec 'initial commit hash' did not match any file(s) known to git.

Currently git may not find the correct commit with depth=1000000 and shallow clone, caused by an error in the final fall back if clause. The comment in the if clause is correct, just missing a 'not' operator for the comment / behavior to work.
@ansibot ansibot added affects_2.11 bug core_review module needs_triage new_contributor small_patch source_control support:core labels Jun 24, 2020
@relrod relrod self-assigned this Jun 25, 2020
@relrod relrod added P3 and removed needs_triage labels Jun 25, 2020
@relrod
Copy link
Member

relrod commented Jun 25, 2020

Can you add a test to show what this is solving, and a changelog fragment?

@ansibot ansibot added the stale_ci label Jul 6, 2020
@ansibot ansibot added needs_revision pre_azp and removed core_review stale_ci labels Dec 6, 2020
@Akasurde
Copy link
Member

Akasurde commented May 28, 2021

@elmeriniemela Are you still working on this? Thanks.

needs_info

@ansibot ansibot added the needs_info label May 28, 2021
@elmeriniemela
Copy link
Author

elmeriniemela commented May 29, 2021

@Akasurde Not really, unfortunately I don't have the resources to develop the tests related to this. Feel free to take this issue further.

@ansibot ansibot removed the needs_info label May 29, 2021
@mattclay
Copy link
Member

mattclay commented Jun 22, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added core_review and removed needs_revision pre_azp labels Jun 22, 2022
@ansibot ansibot added the stale_ci label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.11 bug core_review module new_contributor P3 small_patch source_control stale_ci support:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants