[WIP] Add _post_validate_tags to flatten extended tags that need templating #70329
+237
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests ci_complete
s-hertel
force-pushed
the
post-validate-extended-tags
branch
from
5936b01
to
ead1b5f
Compare
bcoca
requested changes
Jun 26, 2020
lib/ansible/playbook/taggable.py
Outdated
| @@ -42,12 +42,63 @@ def _load_tags(self, attr, ds): | |||
| else: | |||
| raise AnsibleError('tags must be specified as a list', obj=ds) | |||
|
|
|||
| def _post_validate_tags(self, attr, value, templar): | |||
| '''Tags are templatable and use extend=True, so this value | |||
There was a problem hiding this comment.
not just tags, i would make this a generic function for templatable and appendable FieldAttirbutes (tags, environment, module_defaults and conditionals)
There was a problem hiding this comment.
though .. conditionals can get 'iffy' since when: [] is kindof valid
s-hertel
changed the title
This comment has been minimized.
This comment has been minimized.
Akasurde
reviewed
Jul 2, 2020
This comment has been minimized.
This comment has been minimized.
s-hertel
force-pushed
the
post-validate-extended-tags
branch
from
79a8e59
to
deafe52
Compare
s-hertel
force-pushed
the
post-validate-extended-tags
branch
from
deafe52
to
abcfdc6
Compare
s-hertel
force-pushed
the
post-validate-extended-tags
branch
from
993cd21
to
85a2d71
Compare
This comment has been minimized.
This comment has been minimized.
s-hertel
force-pushed
the
post-validate-extended-tags
branch
from
85a2d71
to
9ed9ef7
Compare
…hey provided rather than the resolution
fix taggable mixin
s-hertel
force-pushed
the
post-validate-extended-tags
branch
from
9ed9ef7
to
5083fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
SUMMARY
Fixes #69903
Since the tags FieldAttribute uses
extend=True, we may get a list containing list variables. Post validation needs to flatten and deduplicate those after templating.ISSUE TYPE