Skip forking on a task with a simple when condition or include #70477
+109
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
sivel
changed the title
ansibot
added
needs_revision
samdoran
removed
the
needs_triage
jborean93
reviewed
Jul 17, 2020
| raise ForkShortCircuit(tr) | ||
|
|
||
| def _short_circuit_fork_include(self, host, task, task_vars, templar): | ||
| vars_copy = task_vars.copy() |
There was a problem hiding this comment.
Wouldn't it be better to do the copy in the if statement. Not sure how expensive this operation is but I would have thought task_vars could be quite large if the host has a lot of vars/facts set on it.
| @@ -207,6 +207,9 @@ | |||
| become: yes | |||
| shell: "echo 'SHOW SERVER_VERSION' | psql --tuples-only --no-align --dbname postgres" | |||
| register: postgres_version_resp | |||
| until: postgres_version_resp is successful | |||
There was a problem hiding this comment.
Was this meant to be here?
There was a problem hiding this comment.
This was done because the speedup we get from this results in postgres not having enough time to start up. If this ever merges, I think this incidental test will be removed by then.
| include_args = task.args.copy() | ||
| include_file = include_args.pop('_raw_params', None) | ||
| if not include_file: | ||
| tr = TaskResult( |
There was a problem hiding this comment.
You set tr here but don't do anything with it. The code will just continue along and probably fail at 366 include_file = templar.template(include_file) because include_file is None.
ansibot
added
stale_ci
ansibot
added
the
stale_ci
ansibot
added
needs_revision
ansibot
added
collection
ansibot
added
the
WIP
ansibot
removed
pre_azp
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
SUMMARY
This PR does a conditional evaluation on tasks that do not have loops, and skips forking if the task should be skipped, or if the task is an include.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Using a playbook with an
import_tasksandwhen: falsewith 100pingtasks:With this PR:
Without:
A playbook that I have that does 100 recursive task includes (also does some
debugandset_fact):With this PR:
Without: