Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BusyBox to modify more user fields #70898

Closed

Conversation

relrod
Copy link
Member

@relrod relrod commented Jul 26, 2020

SUMMARY

Change:

  • BusyBox-based distros often don't ship the shadow package and thus
    the usermod command. Thus unless we place a dependency on that
    package, we need to modify /etc/passwd ourselves.
  • This patch does that and now allows us to support uid, primary group,
    GECOS, home directory, and shell.
  • Also update documentation around BusyBox and note which fields are
    currently NOT supported.

Test Plan:

  • Local Alpine VM

Tickets:

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

user module

Change:
- BusyBox-based distros often don't ship the `shadow` package and thus
  the `usermod` command. Thus unless we place a dependency on that
  package, we need to modify /etc/passwd ourselves.
- This patch does that and now allows us to support uid, primary group,
  GECOS, home directory, and shell.
- Also update documentation around BusyBox and note which fields are
  currently NOT supported.

Test Plan:
- Local Alpine VM

Tickets:
- Fixes ansible#66679 (mostly, somewhat)

Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod requested review from bcoca and samdoran Jul 26, 2020
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels Jul 26, 2020
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 28, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 5, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 3, 2020
@mattclay
Copy link
Member

mattclay commented Dec 3, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 3, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 3, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 16, 2020
@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Jan 17, 2021
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 17, 2021
@ansibot ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Mar 6, 2021
@mattclay
Copy link
Member

mattclay commented Apr 13, 2022

@relrod Do you still want to work on this? If so, could you add integration tests since we have Alpine in CI?

@nitzmahone
Copy link
Member

nitzmahone commented Aug 24, 2022

Feel free to reopen with tests if the behavior is still desired...

@nitzmahone nitzmahone closed this Aug 24, 2022
@ansible ansible locked and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. has_issue module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user.py Busybox support broke modifying users
5 participants