Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to list strategy to --list tasks #70995

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jul 30, 2020

while still executing some things like includes

slight variance on #38403

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

list/cli/stratgegy

@ansibot
Copy link
Contributor

ansibot commented Jul 30, 2020

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/plugins/strategy/list.py:37:4: empty-docstring: Empty method docstring
lib/ansible/plugins/strategy/list.py:60:20: unreachable: Unreachable code

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/cli/playbook.py:129:9: E303: too many blank lines (2)
lib/ansible/executor/playbook_executor.py:150:24: E111: indentation is not a multiple of four
lib/ansible/playbook/block.py:377:31: E231: missing whitespace after ','
lib/ansible/plugins/strategy/list.py:82:161: E501: line too long (166 > 160 characters)
lib/ansible/plugins/strategy/list.py:144:33: E303: too many blank lines (2)

click here for bot help

@ansibot ansibot added affects_2.11 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_plugin This PR includes a new plugin. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 30, 2020
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 30, 2020
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jul 31, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 8, 2020
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 24, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 6, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. labels May 18, 2021
@ansibot
Copy link
Contributor

ansibot commented May 18, 2021

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/cli/playbook.py:138:9: E303: too many blank lines (2)
lib/ansible/executor/playbook_executor.py:170:24: E111: indentation is not a multiple of four
lib/ansible/playbook/block.py:373:31: E231: missing whitespace after ','
lib/ansible/plugins/strategy/list.py:82:161: E501: line too long (166 > 160 characters)
lib/ansible/plugins/strategy/list.py:144:33: E303: too many blank lines (2)

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/plugins/strategy/list.py:37:4: empty-docstring: Empty method docstring
lib/ansible/plugins/strategy/list.py:60:20: unreachable: Unreachable code

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 18, 2021
@ansibot
Copy link
Contributor

ansibot commented May 18, 2021

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/executor/playbook_executor.py:170:24: E111: indentation is not a multiple of four
lib/ansible/playbook/block.py:373:31: E231: missing whitespace after ','
lib/ansible/plugins/strategy/list.py:95:161: E501: line too long (166 > 160 characters)
lib/ansible/plugins/strategy/list.py:160:33: E303: too many blank lines (2)

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/plugins/strategy/list.py:38:4: empty-docstring: Empty method docstring
lib/ansible/plugins/strategy/list.py:74:20: unreachable: Unreachable code

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 18, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label May 19, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 27, 2021
  while still executing some things like includes
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Jun 22, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jun 23, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 1, 2021
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 27, 2021
@bcoca bcoca marked this pull request as draft Aug 24, 2022
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.14 ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants