Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-galaxy - source deps from all servers and not just parent #72576

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Nov 10, 2020

SUMMARY

The current logic when coming across a collection dependency is to only search the server that collection was from for that dependency. The upcoming work with Private Automation Hub (Galaxy NG) uses multiple endpoints to sync upstream content and a use case is for end users to upload a collection in their internal repository that can depend on an upstream one. This means we need to change the logic to search for collections in all the user configured servers. This enables a collection in server 1 to have a dependency collection on server 2 and so on.

This code is expected to change in devel at some point in the future with the upcoming refactor but we need to backport this change to stable-2.9 hence why it's being done here as well.

TODO:

  • Add integration tests for this scenario
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-galaxy

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 10, 2020
@jborean93 jborean93 marked this pull request as ready for review November 11, 2020 23:56
@ansibot ansibot added the test This PR relates to tests. label Nov 12, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 12, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 12, 2020
@Shrews Shrews removed the needs_triage Needs a first human triage before being processed. label Nov 12, 2020
@newswangerd
Copy link
Member

LGTM

@ansibot ansibot added has_issue shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 18, 2020
@jborean93
Copy link
Contributor Author

Thanks for testing @newswangerd and @Gianlu.

@jborean93 jborean93 merged commit fb092a8 into ansible:devel Nov 19, 2020
@jborean93 jborean93 deleted the galaxy-sources branch November 19, 2020 18:54
jborean93 added a commit to jborean93/ansible that referenced this pull request Nov 19, 2020
…sible#72576)

* ansible-galaxy - source deps from all servers and not just parent

* Added integration tests for this scenario

(cherry picked from commit fb092a8)
jborean93 added a commit to jborean93/ansible that referenced this pull request Nov 19, 2020
…sible#72576)

* ansible-galaxy - source deps from all servers and not just parent

* Added integration tests for this scenario

(cherry picked from commit fb092a8)
jborean93 added a commit to jborean93/ansible that referenced this pull request Nov 19, 2020
…sible#72576)

* ansible-galaxy - source deps from all servers and not just parent

* Added integration tests for this scenario

(cherry picked from commit fb092a8)
jborean93 added a commit to jborean93/ansible that referenced this pull request Nov 19, 2020
…sible#72576)

* ansible-galaxy - source deps from all servers and not just parent

* Added integration tests for this scenario

(cherry picked from commit fb092a8)
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.9 #72683
stable-2.10 #72684

@ansible ansible locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 feature This issue/PR relates to a feature request. has_issue shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants