Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft autovalidate #72601

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from
Draft

draft autovalidate #72601

wants to merge 1 commit into from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Nov 12, 2020

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

playbooks

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 12, 2020
@ansibot
Copy link
Contributor

ansibot commented Nov 12, 2020

The test ansible-test sanity --test pylint [explain] failed with 11 errors:

lib/ansible/playbook/base.py:617:0: syntax-error: invalid syntax (<unknown>, line 617)
lib/ansible/playbook/block.py:25:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
lib/ansible/playbook/loop_control.py:23:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
lib/ansible/playbook/play.py:28:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
lib/ansible/playbook/play_context.py:33:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
lib/ansible/playbook/playbook_include.py:31:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
lib/ansible/playbook/role/__init__.py:28:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
lib/ansible/playbook/role/definition.py:29:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
lib/ansible/playbook/role/metadata.py:28:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
lib/ansible/playbook/task.py:32:0: syntax-error: Cannot import 'ansible.playbook.base' due to syntax error 'invalid syntax (<unknown>, line 617)'
test/sanity/ignore.txt:134:1: ansible-test: Ignoring 'blacklisted-name' on 'lib/ansible/playbook/base.py' is unnecessary

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t strategy debug free host_pinned linear" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: invalid syntax (base.py, line 617)

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make base_singlehtmldocs' failed with status code: 2
--> Standard Output
../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
Makefile:109: recipe for target 'cli' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 103, in <module>
    main()
  File "../../hacking/build-ansible.py", line 92, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 279, in main
    allvars[cli_name] = opts_docs(cli_class_name, cli_name)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 120, in opts_docs
    fromlist=[cli_class_name]), cli_class_name)
  File "/root/ansible/lib/ansible/cli/adhoc.py", line 13, in <module>
    from ansible.executor.task_queue_manager import TaskQueueManager
  File "/root/ansible/lib/ansible/executor/task_queue_manager.py", line 31, in <module>
    from ansible.executor.play_iterator import PlayIterator
  File "/root/ansible/lib/ansible/executor/play_iterator.py", line 27, in <module>
    from ansible.playbook.block import Block
  File "/root/ansible/lib/ansible/playbook/__init__.py", line 27, in <module>
    from ansible.playbook.play import Play
  File "/root/ansible/lib/ansible/playbook/play.py", line 28, in <module>
    from ansible.playbook.base import Base
  File "/root/ansible/lib/ansible/playbook/base.py", line 617
    return self.'_%s' % key
                    ^
SyntaxError: invalid syntax
make: *** [cli] Error 1

The test ansible-test sanity --test package-data [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/package-data.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 376, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 353, in main
    sdist_path = create_sdist(tmp_dir)
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 167, in create_sdist
    raise Exception('make snapshot failed:\n%s' % stderr)
Exception: make snapshot failed:
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Traceback (most recent call last):
  File "hacking/build-ansible.py", line 103, in <module>
    main()
  File "hacking/build-ansible.py", line 92, in main
    retval = command.main(args)
  File "/tmp/tmpfufp_0fn/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 279, in main
    allvars[cli_name] = opts_docs(cli_class_name, cli_name)
  File "/tmp/tmpfufp_0fn/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 120, in opts_docs
    fromlist=[cli_class_name]), cli_class_name)
  File "/tmp/tmpfufp_0fn/lib/ansible/cli/adhoc.py", line 13, in <module>
    from ansible.executor.task_queue_manager import TaskQueueManager
  File "/tmp/tmpfufp_0fn/lib/ansible/executor/task_queue_manager.py", line 31, in <module>
    from ansible.executor.play_iterator import PlayIterator
  File "/tmp/tmpfufp_0fn/lib/ansible/executor/play_iterator.py", line 27, in <module>
    from ansible.playbook.block import Block
  File "/tmp/tmpfufp_0fn/lib/ansible/playbook/__init__.py", line 27, in <module>
    from ansible.playbook.play import Play
  File "/tmp/tmpfufp_0fn/lib/ansible/playbook/play.py", line 28, in <module>
    from ansible.playbook.base import Base
  File "/tmp/tmpfufp_0fn/lib/ansible/playbook/base.py", line 617
    return self.'_%s' % key
                    ^
SyntaxError: invalid syntax
make: *** [generate_rst] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/playbook/base.py:617:29: SyntaxError: return self.'_%s' % key

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/playbook/base.py:617:29: SyntaxError: return self.'_%s' % key

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/playbook/base.py:617:29: SyntaxError: return self.'_%s' % key

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/playbook/base.py:617:29: SyntaxError: return self.'_%s' % key

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/playbook/base.py:617:29: SyntaxError: return self.'_%s' % key

The test ansible-test sanity --test compile --python 3.8 [explain] failed with 1 error:

lib/ansible/playbook/base.py:617:25: SyntaxError: return self.'_%s' % key

The test ansible-test sanity --test compile --python 3.9 [explain] failed with 1 error:

lib/ansible/playbook/base.py:617:25: SyntaxError: return self.'_%s' % key

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/playbook/base.py:196:5: E303: too many blank lines (2)
lib/ansible/playbook/base.py:623:17: E113: unexpected indentation
lib/ansible/playbook/base.py:627:1: E302: expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 12, 2020
@Shrews Shrews removed the needs_triage Needs a first human triage before being processed. label Nov 12, 2020
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Nov 13, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 21, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 7, 2020
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Feb 16, 2021
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.11 bug This issue/PR relates to a bug. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants