Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight tweak to galaxy source selection #72685

Merged
merged 1 commit into from Nov 19, 2020

Conversation

jborean93
Copy link
Contributor

SUMMARY

#72576 was slightly incorrect and could lead to a bug when the last collection in a requirements list had an explicit server set. This PR makes sure dependencies are resolved in the full API server list.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 19, 2020
@jborean93 jborean93 merged commit 18e5628 into ansible:devel Nov 19, 2020
@jborean93 jborean93 deleted the galaxy-sources branch November 19, 2020 21:54
jborean93 added a commit to jborean93/ansible that referenced this pull request Nov 19, 2020
jborean93 added a commit to jborean93/ansible that referenced this pull request Nov 19, 2020
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Nov 23, 2020
relrod pushed a commit that referenced this pull request Dec 7, 2020
….9 (#72683)

(cherry picked from commit fb092a8)

* Slight tweak to galaxy source selection (#72685)
(cherry picked from commit 18e5628)
relrod pushed a commit that referenced this pull request Dec 8, 2020
….10 (#72684)

* Added integration tests for this scenario

(cherry picked from commit fb092a8)

* Slight tweak to galaxy source selection (#72685)

(cherry picked from commit 18e5628)
@ansible ansible locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants