Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy Features #73373

Draft
wants to merge 4 commits into
base: devel
Choose a base branch
from
Draft

Strategy Features #73373

wants to merge 4 commits into from

Conversation

sivel
Copy link
Member

@sivel sivel commented Jan 26, 2021

SUMMARY
  • Allow strategy plugins to expose their features
  • Use a custom MutableMapping with __eq__ instead of just a dict ?
  • Smuggle strategy features to callbacks
  • Use strategy features in callbacks
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

many?

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 26, 2021
@@ -188,7 +188,7 @@ def _task_start(self, task, prefix=None):

# Preserve task name, as all vars may not be available for templating
# when we need it later
if self._play.strategy == 'free':
if self._play.strategy.get('lockstep', False) is False:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume True as that is the default for most strategies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was debating this, and I picked False. I'll think it over more.

LOCKSTEP = False
BYPASS_HOST_LOOP = True
ANY_ERRORS_FATAL = True

Copy link
Member

@bcoca bcoca Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serial? max_fail_%

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't capture them all. But those are good ideas.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 26, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 26, 2021
@sivel
Copy link
Member Author

sivel commented Jan 26, 2021

I may pause on a better implementation until 2.12.

Once we have py3 only for controller, we're going to look into using typing.Protocol and then a proxy that will only allow access of the interface defined by the union of the Protocol class(es).

Still debating things...

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jan 28, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 5, 2021
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 21, 2021
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 2, 2022
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 30, 2022
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.11 feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants