New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add 'uninstall' subcommand to 'ansible-galaxy collection' #73464
[WIP] Add 'uninstall' subcommand to 'ansible-galaxy collection' #73464
Conversation
8499da4
to
9f9ebf9
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked through everything, but here's a few things I noticed.
lib/ansible/cli/galaxy.py
Outdated
remove_parser.add_argument('-n', '--no-deps', dest='no_deps', action='store_true', default=False, | ||
help="Skip dependencies of the collection(s) to remove") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we remove the deps by default? If anything, I'd require users to add --depclean
(it's an actual argument name from Gentoo's emerge
and is usually quite expensive). Do we track that those deps aren't required by anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to be opt-in. I am checking if the collections (deps and otherwise) are used by anything else (unless --force
is used).
test/integration/targets/ansible-galaxy-collection/tasks/remove.yml
Outdated
Show resolved
Hide resolved
Just adding a note to this, that we aren't going to rush it into 2.11. |
Add tests Changelog
9f9ebf9
to
86bdaa7
Compare
The test
The test
|
04a6ab8
to
af9a474
Compare
The test
The test
|
The test
The test
|
Closing as per @s-hertel requests. Will need to be reworked based on recent changes. |
SUMMARY
Fixes #67759
ISSUE TYPE