New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_log mask suboption fallback values and defaults CVE-2021-20228 #73487
Conversation
|
We'll need a changelog for |
|
The test |
|
I just moved these methods to functions (in my as yet unmerged PR) for use by the arg spec validator. I'll make sure to incorporate these changes once this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of the combination of logic here to reduce duplicate code (reads a bit complex), but it seems equivalent.
|
Thanks for the review all. |
…sible#73487) * no_log mask suboption fallback values and defaults * Added changelog * Remove lambda expression (cherry picked from commit 0cdc410)
…sible#73487) * no_log mask suboption fallback values and defaults * Added changelog * Remove lambda expression (cherry picked from commit 0cdc410)
…sible#73487) * no_log mask suboption fallback values and defaults * Added changelog * Remove lambda expression (cherry picked from commit 0cdc410)
…sible#73487) * no_log mask suboption fallback values and defaults * Added changelog * Remove lambda expression (cherry picked from commit 0cdc410)
SUMMARY
Make sure default and fallback values for
no_logfields are masked in the module output.CVE-2021-20228
ISSUE TYPE
COMPONENT NAME
basic.py