Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [might be horrible] Modulify async_wrapper + remove deprecations #74226

Draft
wants to merge 4 commits into
base: devel
Choose a base branch
from
Draft

[WIP] [might be horrible] Modulify async_wrapper + remove deprecations #74226

wants to merge 4 commits into from
+122 −194

Conversation

relrod
Copy link
Member

@relrod relrod commented Apr 11, 2021

SUMMARY

Change:

  • Remove use of ANSIBLE_ASYNC_DIR from ActionBase and async_status.
  • Use AnsibleModule in async_wrapper to take args including async_dir
    without hacky argv parsing and env vars.
  • Remove duplicate _filter_non_json_lines() implementation.
  • Drop py24 hack in async_wrapper.py.
  • Drop use of ANSIBLE_ASYNC_DIR from async tests.
  • Add porting guide and changelog docs.

Test Plan:

  • ci_complete

Tickets:

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

async_wrapper

@relrod
Modulify async_wrapper + remove deprecations
7f4e6d9 
Change:
- Remove use of ANSIBLE_ASYNC_DIR from ActionBase and async_status.
- Use AnsibleModule in async_wrapper to take args including async_dir
  without hacky argv parsing and env vars.
- Remove duplicate _filter_non_json_lines() implementation.
- Drop py24 hack in async_wrapper.py.
- Drop use of ANSIBLE_ASYNC_DIR from async tests.
- Add porting guide and changelog docs.

Test Plan:
- ci_complete

Tickets:
- Fixes ansible#74139
- Fixes ansible#74138

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.12 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 11, 2021
@relrod relrod added the ci_verified Changes made in this PR are causing tests to fail. label Apr 11, 2021
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 11, 2021
@ansibot

This comment has been minimized.

Sign in to view
@relrod
Don't pass arg_path, it's sent as module arg now
a00c89d 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
lint
e9dbedc 
Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added the test This PR relates to tests. label Apr 11, 2021
@relrod
nuke wrong new test, breaks on py35
1c56168 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod closed this Apr 12, 2021
relrod added a commit to relrod/ansible that referenced this pull request Apr 12, 2021
@relrod
Remove (only) user-facing use of ANSIBLE_ASYNC_DIR
0036135 
Change:
- Remove only user-facing use of ANSIBLE_ASYNC_DIR.
- Remove two comments saying to change things that, apparently, we
  aren't going to change...

Test Plan:
- ci_complete

Tickets:
- Fixes ansible#74139
- Fixes ansible#74138
- Refs ansible#74226

Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod mentioned this pull request Apr 12, 2021
Merged
@relrod relrod reopened this Apr 13, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 13, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 21, 2021
sivel pushed a commit to relrod/ansible that referenced this pull request Sep 17, 2021
@relrod @sivel
Remove (only) user-facing use of ANSIBLE_ASYNC_DIR
a84e297 
Change:
- Remove only user-facing use of ANSIBLE_ASYNC_DIR.
- Remove two comments saying to change things that, apparently, we
  aren't going to change...

Test Plan:
- ci_complete

Tickets:
- Fixes ansible#74139
- Fixes ansible#74138
- Refs ansible#74226

Signed-off-by: Rick Elrod <rick@elrod.me>
sivel pushed a commit that referenced this pull request Sep 17, 2021
@relrod
Remove (only) user-facing use of ANSIBLE_ASYNC_DIR (#74249)
61f5c22 
Change:
- Remove only user-facing use of ANSIBLE_ASYNC_DIR.
- Remove two comments saying to change things that, apparently, we
  aren't going to change...

Test Plan:
- ci_complete

Tickets:
- Fixes #74139
- Fixes #74138
- Refs #74226

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 2, 2022
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 18, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. has_issue module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
3 participants
@relrod @ansibot @samdoran