Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[toml] Increase test coverage #74236

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

relrod
Copy link
Member

@relrod relrod commented Apr 12, 2021

SUMMARY

Change:

  • This gets us to around 88% test coverage of the toml plugin
    (give or take any coverage other roles add).

Test Plan:

  • Local test runs

Tickets:

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

toml

Change:
- This gets us to around 88% test coverage of the toml plugin
  (give or take any coverage other roles add).

Test Plan:
- Local test runs

Tickets:
- Depends on ansible#74234

Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod marked this pull request as draft April 12, 2021 09:33
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.12 needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 12, 2021
@ansibot

This comment has been minimized.

@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Apr 12, 2021
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod added the ci_verified Changes made in this PR are causing tests to fail. label Apr 12, 2021
Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 12, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 13, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 21, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 18, 2023
@mattclay
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattclay mattclay added ci_verified Changes made in this PR are causing tests to fail. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Jul 13, 2023
@mattclay
Copy link
Member

This PR needs to be rebased before CI can run.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. labels Jul 13, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.12 needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants