Skip to content

optimize config for making it on demand and fix deprecation warnings#74774

Draft
bcoca wants to merge 5 commits intoansible:develfrom
bcoca:config_opt
Draft

optimize config for making it on demand and fix deprecation warnings#74774
bcoca wants to merge 5 commits intoansible:develfrom
bcoca:config_opt

Conversation

@bcoca
Copy link
Member

@bcoca bcoca commented May 19, 2021

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

config

nitzmahone
nitzmahone reviewed May 19, 2021
View reviewed changes
@ansibot ansibot added affects_2.12 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels May 19, 2021
@samdoran samdoran added ci_verified Changes made in this PR are causing tests to fail. and removed needs_triage Needs a first human triage before being processed. labels May 20, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels May 21, 2021
@bcoca bcoca changed the title optimize config for making it on demand optimize config for making it on demand, fix deprecation warnings May 24, 2021
@bcoca bcoca changed the title optimize config for making it on demand, fix deprecation warnings optimize config for making it on demand and fix deprecation warnings May 24, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Sep 23, 2021
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Sep 23, 2021
@bcoca bcoca changed the title [requires controller ci separation] optimize config for making it on demand and fix deprecation warnings optimize config for making it on demand and fix deprecation warnings Sep 23, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 1, 2021
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 19, 2022
@bcoca bcoca marked this pull request as draft August 24, 2022 19:37
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Aug 24, 2022
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jul 25, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Oct 24, 2023
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Jan 28, 2025
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_pr This PR has not been pushed to for more than one year. labels Jun 10, 2025
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jun 10, 2025
@ansibot
Copy link
Contributor

ansibot commented Jun 10, 2025

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/constants.py:178:1: E266: too many leading '#' for block comment
lib/ansible/constants.py:194:13: E722: do not use bare 'except'

click here for bot help

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 10, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitzmahone nitzmahone nitzmahone left review comments

Assignees

No one assigned

Labels

affects_2.12 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bcoca @mattclay @ansibot @nitzmahone @samdoran