Skip to content

minor path related fixes - #75108

Draft
bcoca wants to merge 1 commit into
ansible:develfrom
bcoca:minor_fixes
Draft

minor path related fixes#75108
bcoca wants to merge 1 commit into
ansible:develfrom
bcoca:minor_fixes

Conversation

@bcoca

@bcoca bcoca commented Jun 24, 2021

Copy link
Copy Markdown
Member
  • newer exception used
  • actually use warning for warning, not display
  • updated and completed comments
  • global exception handler now recommends -vvv
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

misc

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review needs_triage Needs a first human triage before being processed. networking Network category needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 24, 2021
Akasurde
Akasurde reviewed Jun 25, 2021
View reviewed changes
Comment thread lib/ansible/utils/path.py
@ansibot ansibot added core_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 25, 2021
@bcoca bcoca changed the title minor fixes [requires controller/target test separation] minor fixes Jun 25, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review labels Jun 25, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jun 25, 2021
@bcoca bcoca mentioned this pull request Jun 25, 2021
Merged
@ansibot ansibot added core_review needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review labels Jun 28, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jun 30, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 8, 2021
@mattclay

mattclay commented Sep 23, 2021

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Sep 23, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 7, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review labels Feb 7, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 2, 2022
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 12, 2022
@bcoca
bcoca marked this pull request as draft July 21, 2022 18:16
@ansibot ansibot added the WIP label Jul 21, 2022
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Oct 24, 2023
Aurimejia

This comment was marked as spam.

Sign in to view

@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 25, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 8, 2024
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 25, 2024
@ansible ansible deleted a comment from ansibot Jul 25, 2024
@ansible ansible deleted a comment from ansibot Jul 25, 2024
@ansible ansible deleted a comment from ansibot Jul 26, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jul 26, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 9, 2024
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 14, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 10, 2024
@bcoca
moar details on -vvv
584b227 
deprecated and substituted usage of makedirs_safe
fix unit tests and random bug
fixed imports
adjust version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akasurde Akasurde Akasurde left review comments
+1 more reviewer
@Aurimejia Aurimejia Aurimejia left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

affects_2.12 bug This issue/PR relates to a bug. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bcoca @mattclay @Akasurde @Aurimejia @webknjaz @samdoran @ansibot