Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new set_var #75215

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

new set_var #75215

wants to merge 2 commits into from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jul 8, 2021

allow more flexible var setting

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

set_var

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.12 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 8, 2021
@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2021

The test ansible-test sanity --test shellcheck [explain] failed with 1 error:

test/integration/targets/interpreter_discovery_python/tasks/library/bashmodule.sh:1:1: SC2148: Tips depend on target shell and yours is unknown. Add a shebang.

The test ansible-test sanity --test shebang [explain] failed with 1 error:

test/integration/targets/interpreter_discovery_python/tasks/library/bashmodule.sh:0:0: file without shebang should not be executable

The test ansible-test sanity --test action-plugin-docs [explain] failed with 1 error:

lib/ansible/plugins/action/set_var.py:0:0: action plugin has no matching module to provide documentation

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/executor/task_executor.py:658:33: undefined-variable: Undefined variable 'results'

click here for bot help

@ansibot ansibot added collection Related to Ansible Collections work collection:dominion_solutions.cloudflare module This issue/PR relates to a module. new_module This PR includes a new module. labels Jul 8, 2021
@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2021

The test ansible-test sanity --test shellcheck [explain] failed with 1 error:

test/integration/targets/interpreter_discovery_python/tasks/library/bashmodule.sh:1:1: SC2148: Tips depend on target shell and yours is unknown. Add a shebang.

The test ansible-test sanity --test shebang [explain] failed with 1 error:

test/integration/targets/interpreter_discovery_python/tasks/library/bashmodule.sh:0:0: file without shebang should not be executable

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/action/set_var.py:44:161: E501: line too long (166 > 160 characters)

The test ansible-test sanity --test action-plugin-docs [explain] failed with 1 error:

lib/ansible/plugins/action/set_var.py:0:0: action plugin has no matching module to provide documentation

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/set_vars.py:0:0: invalid-documentation: DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'Ansible Project'
lib/ansible/modules/set_vars.py:0:0: invalid-documentation: DOCUMENTATION.options.scope.type: not a valid value for dictionary value @ data['options']['scope']['type']. Got 'string'
lib/ansible/modules/set_vars.py:0:0: missing-return: No RETURN provided

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/executor/task_executor.py:658:33: undefined-variable: Undefined variable 'results'

click here for bot help

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 8, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 16, 2021
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 2, 2022
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 6, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.12 collection:arista.avd collection Related to Ansible Collections work feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants