Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Sanity test to validate galaxy.yml metadata file for the required keys #75335

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

WIP: Sanity test to validate galaxy.yml metadata file for the required keys #75335

wants to merge 4 commits into from
+96 −0

Conversation

Ompragash
Copy link
Contributor

SUMMARY

Added a new sanity test galaxy-metadata to validate collection galaxy.yml metadata file for the required keys.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME
  • ansible-test

@ansibot
Copy link
Contributor

ansibot commented Jul 27, 2021

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/dev_guide/testing/sanity/index.rst:11:0: toc-tree-missing-document: toctree contains reference to nonexisting document 'dev_guide/testing/sanity/galaxy-metadata'

The test ansible-test sanity --test sanity-docs [explain] failed with 1 error:

docs/docsite/rst/dev_guide/testing/sanity/galaxy-metadata.rst:0:0: missing docs for ansible-test sanity --test galaxy-metadata

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

test/lib/ansible_test/_data/sanity/code-smell/galaxy-metadata.py:15:1: E302: expected 2 blank lines, found 1
test/lib/ansible_test/_data/sanity/code-smell/galaxy-metadata.py:67:1: E305: expected 2 blank lines after class or function definition, found 1

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

test/lib/ansible_test/_data/sanity/code-smell/galaxy-metadata.py:22:81: undefined-variable: Undefined variable 're'
test/lib/ansible_test/_data/sanity/code-smell/galaxy-metadata.py:26:27: undefined-variable: Undefined variable 're'

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.12 needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 27, 2021
@ansibot ansibot added docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Jul 28, 2021
@ansibot
Copy link
Contributor

ansibot commented Jul 28, 2021

The test ansible-test sanity --test no-smart-quotes [explain] failed with 1 error:

docs/docsite/rst/dev_guide/testing/sanity/galaxy-metadata.rst:5:28: use ASCII quotes `'` and `"` instead of Unicode quotes

click here for bot help

@Ompragash
Copy link
Contributor Author

/rebuild_failed

@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Jul 29, 2021
@sivel
Copy link
Member

sivel commented Jul 29, 2021

We're waffling on this a bit. We're concerned about how we properly handle this across versions, as we've changed the schema by adding new keys a few times. We do effectively own the galaxy.yml schema, but it's an intermediate file that is only used during build time.

The better test may be that we need the ability to run a galaxy-importer test, or just allow that to happen external of ansible-test. A proper galaxy-importer test would be to first build the artifact, and then run it through galaxy-importer.

Ultimately using galaxy-importer that includes a build step is going to verify much more, and the code already exists.

Thoughts?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 6, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 10, 2023
@mattclay
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Jul 13, 2023
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jul 13, 2023
@mattclay
Copy link
Member

This PR needs to be rebased before CI can run.

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 13, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde left review comments

Assignees
No one assigned
Labels
affects_2.12 docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ompragash @ansibot @sivel @mattclay @Akasurde @nitzmahone