Skip to content

fix task state handling #75854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bcoca wants to merge 12 commits into
base: devel
Choose a base branch
from
Draft

fix task state handling #75854

bcoca wants to merge 12 commits into from
+42 −35

Conversation

@bcoca
Copy link
Member

@bcoca bcoca commented Sep 30, 2021

dont let actions, unreachable and timeout bypass loops error handling

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

coire

@ansibot ansibot added affects_2.13 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 30, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Oct 4, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 5, 2021
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Oct 5, 2021
@bcoca bcoca mentioned this pull request Oct 12, 2021
Closed
1 task
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. has_issue labels Oct 13, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 29, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 6, 2021
@bcoca bcoca force-pushed the fix_result_handling branch from 0369acd to e0b9465 Compare February 3, 2022 21:19
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 3, 2022
@bcoca bcoca force-pushed the fix_result_handling branch from e0b9465 to 305e333 Compare September 24, 2024 16:23
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 24, 2024
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 24, 2024
nitzmahone
nitzmahone reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found a crapload of holes around this stuff in DT- we fixed some of the obvious ones and centralized a lot of the exception/dict conversion stuff, but we need to have a broader discussion and actually document some of the corner/overlapping cases between unreachable and error...

@bcoca
Copy link
Member Author

bcoca commented Sep 24, 2024

i was going to hold this back till DT, but since that got postponed, this fixes some cases, happy to include more if you have those.

@mattclay
Copy link
Member

mattclay commented Sep 24, 2024

@bcoca What is this fixing? Is there a bug report/reproducer for the issue?

@bcoca
Copy link
Member Author

bcoca commented Sep 25, 2024

@mattclay it should be clear once i add tests, but it allows result handling to be uniform across task end points (changed_when, failed_when, etc).

@bcoca bcoca mentioned this pull request Oct 1, 2024
Closed
1 task
@ansible ansible deleted a comment from ansibot Oct 2, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 2, 2024
bcoca added 2 commits October 3, 2024 18:27
@bcoca
fix loop/ignore settings
dea9862 
also simplify result loops and add comments to intention
@bcoca
update clog
dcbfe74
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 3, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 18, 2024
@ansible ansible deleted a comment from ansibot Oct 28, 2024
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 28, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Nov 4, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 11, 2024
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitzmahone nitzmahone nitzmahone left review comments

Assignees

No one assigned

Labels

affects_2.14 bug This issue/PR relates to a bug. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_pr This PR has not been pushed to for more than one year. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bcoca @ansibot @webknjaz @mattclay @nitzmahone @mkrizek @samdoran @s-hertel