Skip to content

Extract useful code out of fetch_url #76313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
sivel wants to merge 14 commits into
base: devel
Choose a base branch
from
Draft

Extract useful code out of fetch_url #76313

sivel wants to merge 14 commits into from
+155 −78

Conversation

@sivel
Copy link
Member

@sivel sivel commented Nov 17, 2021 •
edited
Loading

SUMMARY

Extract useful code out of fetch_url

This can potentially ease the over reliance on fetch_url, moving more plugin authors to Request, but offering some added functionality to perform similar processing to what fetch_url was solely responsible for:

  • normalizing headers
  • processing cookies
  • handling common exceptions

Fixes #54721

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/urls.py

ADDITIONAL INFORMATION

Required:

  • docs
  • tests

sivel
sivel commented Nov 17, 2021
View reviewed changes
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.13 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 17, 2021
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Nov 18, 2021
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 2, 2022
@sivel sivel force-pushed the fetch-url-do-less branch from ca3201f to 06bfe5f Compare September 6, 2022 19:41
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 6, 2022
@sivel sivel marked this pull request as ready for review September 7, 2022 15:43
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Sep 7, 2022
@sivel sivel force-pushed the fetch-url-do-less branch from e773aec to 507697f Compare September 8, 2022 20:15
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 12, 2022
@mattclay mattclay marked this pull request as draft March 22, 2023 19:54
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Mar 22, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Oct 24, 2023
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Jan 28, 2025
@sivel sivel added the unimportant_ci This PR does not need to have healthy CI status and should be ignored by the CI infra maintainers. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

affects_2.13 feature This issue/PR relates to a feature request. has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_pr This PR has not been pushed to for more than one year. support:core This issue/PR relates to code supported by the Ansible Engineering Team. unimportant_ci This PR does not need to have healthy CI status and should be ignored by the CI infra maintainers. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple 'set-cookie' python 3

2 participants

@sivel @ansibot