harden service_facts states and add new output variable load_states#76667
Open
jameslivulpi wants to merge 7 commits intoansible:develfrom
Open
harden service_facts states and add new output variable load_states#76667jameslivulpi wants to merge 7 commits intoansible:develfrom
jameslivulpi wants to merge 7 commits intoansible:develfrom
Conversation
Contributor
Author
|
I added some comments on the rationale behind some of changes in code, will remove those later and lint code further. |
This comment has been minimized.
This comment has been minimized.
bcoca
requested changes
Jan 11, 2022
Contributor
Author
|
Reason I changed |
justin-f-perez
suggested changes
Jan 12, 2022
Co-authored-by: justin-f-perez <justin.f.perez@gmail.com>
bcoca
reviewed
Jan 12, 2022
bcoca
reviewed
Jan 12, 2022
bcoca
reviewed
Jan 12, 2022
- Revert state description - Add version_added to load_state
1 task
Member
|
sorry for the delay on getting back, can you rebase the PR? |
Contributor
|
Nice to see --no-legend being added. |
Member
|
note (not for immediate action): i've been thinking about this and more general PRs, adding a 'extended_info' for the plugin and then allow for each 'service system' to attach all 'extra' information seems a better approach than adding piece by piece the information to solve one problem at a time. i.e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
#76629
ISSUE TYPE
COMPONENT NAME
service_facts