ansible-galaxy collection search #77064
Draft
+64
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.13
core_review
s-hertel
reviewed
Feb 21, 2022
| @@ -238,6 +238,7 @@ def init_parser(self): | |||
| self.add_install_options(collection_parser, parents=[common, force, cache_options]) | |||
| self.add_list_options(collection_parser, parents=[common, collections_path]) | |||
| self.add_verify_options(collection_parser, parents=[common, collections_path]) | |||
| self.add_search_options(collection_parser, parents=[common]) | |||
There was a problem hiding this comment.
All the options show up with ansible-galaxy collection search --help right now but filtering by author (github username)/platform doesn't work for collections I think. add_search_options could add a --namespace option + not add --author/--platform for collections.
There was a problem hiding this comment.
need to find the name of the parameters that work before i can add them, right now i just found one that works , mostly by accident
| # https://galaxy.ansible.com/search?keywords=<term>&order_by=-relevance&deprecated=false&type=collection&page=1 | ||
| # api_path = self.available_api_versions.get('v3', self.available_api_versions.get('v2')) | ||
| # url_paths = [self.api_server, api_path, 'collections', '/?search=%s' % term] | ||
| url_paths = ['https://galaxy.ansible.com', 'api', 'internal', 'ui', 'search', '/?type=collection&deprecated=false&keywords=%s' % term] |
There was a problem hiding this comment.
Could use self.api_server instead:
Suggested change
| url_paths = ['https://galaxy.ansible.com', 'api', 'internal', 'ui', 'search', '/?type=collection&deprecated=false&keywords=%s' % term] | |
| url_paths = [self.api_server, 'internal', 'ui', 'search', '/?type=collection&deprecated=false&keywords=%s' % term] |
Unless it's hardcoded because it doesn't work with v3?
There was a problem hiding this comment.
isn't v2 community galaxy collections? v1 is roles
But noticed the conversation about internal/ui not being a supported, so it doesn't really matter.
There was a problem hiding this comment.
for roles we still use the v1, i tried equivalent v2 and v3 but could not find, will resolve with help of galaxy team
bcoca
removed
the
needs_triage
bcoca
changed the title
ansibot
added
the
stale_ci
3 tasks
bcoca
changed the title
ansibot
added
WIP
ansibot
added
the
needs_rebase
1 task
ansibot
removed
needs_rebase
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
ansibot
added
needs_rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
ansible-galaxy