Add pid tracking to async_wrapper, add terminate functionality to async_status #77196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
- hosts: localhost
gather_facts: false
tasks:
- command: sleep 100
async: 100
poll: 0
register: result
- async_status:
jid: '{{ result.ansible_job_id }}'
- async_status:
jid: '{{ result.ansible_job_id }}'
mode: terminate
- async_status:
jid: '{{ result.ansible_job_id }}'
register: fail_result
ignore_errors: true
- assert:
that:
- fail_result is failed |
ansibot
added
WIP
jborean93
removed
the
needs_triage
ansibot
added
the
support:community
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
added
core_review
ansibot
added
the
stale_ci
bcoca
reviewed
Mar 21, 2022
| type: str | ||
| choices: [ cleanup, status ] | ||
| choices: [ cleanup, status, terminate ] |
There was a problem hiding this comment.
we should add note that 'terminate' was added in version 2.13
There was a problem hiding this comment.
or move to 'dictionary' choices which can have their own version_added
bcoca
reviewed
Mar 21, 2022
| finished=data['finished'], | ||
| msg="Missing pid, cannot terminate" | ||
| ) | ||
| else: |
ansibot
added
needs_rebase
ansibot
added
the
WIP
ansibot
removed
the
needs_revision
|
Hi. Still working on this ? If not, would you mind me picking it up and trying to get it merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add pid tracking to async_wrapper, add terminate functionality to async_status
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/async_status.py
ADDITIONAL INFORMATION