[PoC] Add loop_control.lookup#77614
Draft
sivel wants to merge 5 commits into
Draft
Conversation
aa0826f to
b9c5628
Compare
b9c5628 to
b336f31
Compare
…thout explicit lookup call
b336f31 to
f164b82
Compare
sivel
commented
Mar 30, 2023
| if self._task.loop_with in self._shared_loader_obj.lookup_loader: | ||
| loop_with = self._task.loop_with | ||
| elif self._task.loop_control: | ||
| loop_with = templar.template(self._task.loop_control.lookup) |
Member
Author
There was a problem hiding this comment.
This explicit templar call may be unnecessary now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add loop_control.lookup to provide a transition from with_ to loop without explicit lookup call
ISSUE TYPE
COMPONENT NAME
lib/ansible/playbook/loop_control.py
ADDITIONAL INFORMATION
Example:
Using
with_fileglob:Using
loop+ lookup:Using
loop_control.lookup: