-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Add loop_control.lookup #77614
Draft
sivel
wants to merge
5
commits into
ansible:devel
Choose a base branch
from
sivel:loop-control-lookup
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
affects_2.14
feature
This issue/PR relates to a feature request.
needs_triage
Needs a first human triage before being processed.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Apr 22, 2022
bcoca
removed
the
needs_triage
Needs a first human triage before being processed.
label
Apr 26, 2022
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
May 4, 2022
ansibot
added
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Jun 21, 2022
sivel
force-pushed
the
loop-control-lookup
branch
from
September 1, 2022 17:43
aa0826f
to
b9c5628
Compare
ansibot
removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Sep 1, 2022
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Sep 9, 2022
ansibot
added
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Sep 17, 2022
sivel
force-pushed
the
loop-control-lookup
branch
from
September 21, 2022 14:08
b9c5628
to
b336f31
Compare
ansibot
removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Sep 21, 2022
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Sep 29, 2022
ansibot
added
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Feb 28, 2023
…thout explicit lookup call
sivel
force-pushed
the
loop-control-lookup
branch
from
March 30, 2023 22:43
b336f31
to
f164b82
Compare
sivel
commented
Mar 30, 2023
if self._task.loop_with in self._shared_loader_obj.lookup_loader: | ||
loop_with = self._task.loop_with | ||
elif self._task.loop_control: | ||
loop_with = templar.template(self._task.loop_control.lookup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This explicit templar call may be unnecessary now
ansibot
removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Mar 30, 2023
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Apr 12, 2023
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
labels
Jul 12, 2023
ansibot
added
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
and removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
labels
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects_2.14
fallible
This issue/PR is a candidate for fallible
feature
This issue/PR relates to a feature request.
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add loop_control.lookup to provide a transition from with_ to loop without explicit lookup call
ISSUE TYPE
COMPONENT NAME
lib/ansible/playbook/loop_control.py
ADDITIONAL INFORMATION
Example:
Using
with_fileglob
:Using
loop
+ lookup:Using
loop_control.lookup
: