[PoC] Allow connection plugins to decline pipelining dynamically

[sivel]

SUMMARY

Allow connection plugins to decline pipelining dynamically

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Allows a plugin, regardless of the pipelining configuration, to decline the ability to use pipelining dynamically. Such as the event where -tt or -o RequestTTY=force is providing in ansible_ssh_extra_args

[bcoca]

We already have a class attribute has_pipelining that is checked (but mostly for module execution, that is bypassed/ignored for discovery). Which discovery seems to already look at https://github.com/ansible/ansible/blob/devel/lib/ansible/executor/interpreter_discovery.py#L99

We could disable pipelining dynamically by updating this attribute instead of creating a new check function, then just use this in the discovery code.

[bcoca]

he, i do love the use of argparse to deal with 'figuring out' the ssh args passed
+1

[sivel]

We already have a class attribute has_pipelining that is checked

I was conflicted on whether or not to use that. I was operating off of the assumption that has_pipelining indicated that the plugin supported it, as opposed to some dynamic decision about whether it could be used in a specific instance, so I didn't want to overload.

We can discuss this more.

But I did overlook that line in interpreter discovery, so I could at minimum move the additional check there, and out of ActionBase for discovery.

[bcoca]

plugins that support toggle for 'pipelinging' now do it in config, should we integrate this into that?